[DRAFT][PYAPI] Retry with explicit UTF-8 path decoding.#36302
Open
mryzhov wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
category: inference
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the runtime cache directory path handling to better support non-ASCII (UTF-8) CACHE_DIR values on Windows, particularly for Python API scenarios, and adds Windows-only Python regression tests to cover Unicode cache directory names.
Changes:
- Add a Windows-only fallback in cache directory parsing to retry path creation using
std::filesystem::u8path()if the initial conversion throws. - Add Windows-only Python tests that set
CACHE_DIRto non-ASCII paths (including emoji/Cyrillic) via bothstrandpathlib.Path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/inference/src/dev/core_impl.cpp | Adds a Windows fallback path decoding attempt for CACHE_DIR when converting from config. |
| src/bindings/python/tests/test_runtime/test_core.py | Adds Windows-only regression tests for Unicode CACHE_DIR values passed to Core.read_model(...). |
Comment on lines
+432
to
+433
| // Python bindings pass UTF-8 strings; if locale-based conversion fails, | ||
| // retry with explicit UTF-8 path decoding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
AI Assistance: