Skip to content

Commit 21cc17f

Browse files
committed
chore: change max_constraint_degree for testing
1 parent acd55ec commit 21cc17f

File tree

4 files changed

+30
-11
lines changed

4 files changed

+30
-11
lines changed

crates/stark-backend-v2/src/proof.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -485,13 +485,13 @@ mod tests {
485485
#[test]
486486
fn test_interactions_proof_encode_decode() -> Result<()> {
487487
let fx = InteractionsFixture11;
488-
let params = test_system_params_small(2, 5, 3);
488+
let params = test_system_params_small(2, 5, 3, 3);
489489
test_proof_encode_decode(fx, params)
490490
}
491491

492492
#[test]
493493
fn test_cached_proof_encode_decode() -> Result<()> {
494-
let params = test_system_params_small(2, 5, 3);
494+
let params = test_system_params_small(2, 5, 3, 3);
495495
let fx = CachedFixture11::new(params.clone());
496496
test_proof_encode_decode(fx, params)
497497
}

crates/stark-backend-v2/src/test_utils.rs

Lines changed: 24 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -482,21 +482,40 @@ impl SystemParams {
482482
/// **These parameters should not be used in production!**
483483
pub fn new_for_testing(log_trace_height: usize) -> Self {
484484
let l_skip = 4;
485-
test_system_params_small(4, log_trace_height - l_skip, 4)
485+
let k_whir = 4;
486+
let max_constraint_degree = 4;
487+
test_system_params_small(
488+
l_skip,
489+
log_trace_height - l_skip,
490+
k_whir,
491+
max_constraint_degree,
492+
)
486493
}
487494
}
488495

489496
/// Trace heights cannot exceed 2^{l_skip + n_stack} when using these system params.
490-
pub fn test_system_params_small(l_skip: usize, n_stack: usize, k_whir: usize) -> SystemParams {
497+
pub fn test_system_params_small(
498+
l_skip: usize,
499+
n_stack: usize,
500+
k_whir: usize,
501+
max_constraint_degree: usize,
502+
) -> SystemParams {
491503
let log_final_poly_len = (n_stack + l_skip) % k_whir;
492-
test_system_params_small_with_poly_len(l_skip, n_stack, k_whir, log_final_poly_len)
504+
test_system_params_small_with_poly_len(
505+
l_skip,
506+
n_stack,
507+
k_whir,
508+
log_final_poly_len,
509+
max_constraint_degree,
510+
)
493511
}
494512

495513
pub fn test_system_params_small_with_poly_len(
496514
l_skip: usize,
497515
n_stack: usize,
498516
k_whir: usize,
499517
log_final_poly_len: usize,
518+
max_constraint_degree: usize,
500519
) -> SystemParams {
501520
assert!(log_final_poly_len < l_skip + n_stack);
502521
let log_blowup = 1;
@@ -507,7 +526,7 @@ pub fn test_system_params_small_with_poly_len(
507526
log_blowup,
508527
whir: test_whir_config_small(log_blowup, l_skip + n_stack, k_whir, log_final_poly_len),
509528
logup: log_up_security_params_baby_bear_100_bits(),
510-
max_constraint_degree: 3,
529+
max_constraint_degree,
511530
}
512531
}
513532

@@ -527,7 +546,7 @@ pub fn test_whir_config_small(
527546
}
528547

529548
pub fn default_test_params_small() -> SystemParams {
530-
test_system_params_small(2, 8, 3)
549+
test_system_params_small(2, 8, 3, 3)
531550
}
532551

533552
pub fn test_engine_small() -> BabyBearPoseidon2CpuEngineV2<DuplexSponge> {

crates/stark-backend-v2/src/tests.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ fn test_batch_constraints_with_interactions() -> eyre::Result<()> {
453453
#[test]
454454
fn test_matrix_stacking_overflow() {
455455
setup_tracing();
456-
let params = test_system_params_small(3, 5, 3);
456+
let params = test_system_params_small(3, 5, 3, 3);
457457
let engine = BabyBearPoseidon2CpuEngineV2::<DuplexSponge>::new(params);
458458
let fx = SelfInteractionFixture {
459459
widths: vec![4, 7, 8, 8, 10],

crates/stark-backend-v2/src/verifier/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ mod tests {
246246
n_stack: usize,
247247
k_whir: usize,
248248
) -> Result<(), VerifierError> {
249-
let params = test_system_params_small(l_skip, n_stack, k_whir);
249+
let params = test_system_params_small(l_skip, n_stack, k_whir, 3);
250250
let engine = BabyBearPoseidon2CpuEngineV2::new(params);
251251
let fx = InteractionsFixture11;
252252
let (pk, vk) = fx.keygen(&engine);
@@ -267,7 +267,7 @@ mod tests {
267267
k_whir: usize,
268268
) -> Result<(), VerifierError> {
269269
setup_tracing_with_log_level(Level::DEBUG);
270-
let params = test_system_params_small(l_skip, n_stack, k_whir);
270+
let params = test_system_params_small(l_skip, n_stack, k_whir, 3);
271271
let engine = BabyBearPoseidon2CpuEngineV2::new(params.clone());
272272
let fx = CachedFixture11::new(params);
273273
let (pk, vk) = fx.keygen(&engine);
@@ -287,7 +287,7 @@ mod tests {
287287
k_whir: usize,
288288
) -> Result<(), VerifierError> {
289289
use itertools::Itertools;
290-
let params = test_system_params_small(l_skip, n_stack, k_whir);
290+
let params = test_system_params_small(l_skip, n_stack, k_whir, 3);
291291
let engine = BabyBearPoseidon2CpuEngineV2::new(params);
292292
let log_trace_degree = 8;
293293
let height = 1 << log_trace_degree;

0 commit comments

Comments
 (0)