Merge pull request #409 from openwallet-foundation-labs/fix/roles

fix: optimize role handling

Author: cre8

apps/backend/src/auth/client/adapters/keycloak-clients.service.ts

@@ -6,7 +6,7 @@ import { InjectRepository } from "@nestjs/typeorm";
 import { decodeJwt } from "jose";
 import { Repository } from "typeorm";
 import { ConfigImportOrchestratorService } from "../../../shared/utils/config-import/config-import-orchestrator.service";
-import { Role } from "../../roles/role.enum";
+import { allRoles, Role } from "../../roles/role.enum";
 import { ClientsProvider } from "../client.provider";
 import { CreateClientDto } from "../dto/create-client.dto";
 import { UpdateClientDto } from "../dto/update-client.dto";
@@ -66,14 +66,7 @@ export class KeycloakClientsProvider
      * Checks if all the roles are available in the realm. If not they will be created.
      */
     private init() {
-        const existingRoles: Role[] = [
-            Role.Tenants,
-            Role.Tenants,
-            Role.IssuanceOffer,
-            Role.Issuances,
-            Role.PresentationOffer,
-            Role.Presentations,
-        ];
+        const existingRoles: Role[] = allRoles;
         return this.kc.roles
             .find()
             .then((roles) => {

apps/backend/src/auth/roles/role.enum.ts

@@ -1,3 +1,6 @@
+/**
+ * Enumeration of all roles available in the system.
+ */
 export enum Role {
     //to manage presentation resources
     Presentations = "presentation:manage",
@@ -14,3 +17,16 @@ export enum Role {
     // to manage registrar configuration and operations
     Registrar = "registrar:manage",
 }
+
+/**
+ * List of all roles
+ */
+export const allRoles = [
+    Role.Tenants,
+    Role.IssuanceOffer,
+    Role.Issuances,
+    Role.PresentationOffer,
+    Role.Presentations,
+    Role.Clients,
+    Role.Registrar,
+];