Clean up some typescript issues

Author: bkeepers

src/astronomy/index.ts

@@ -3,7 +3,7 @@ import coefficients from './coefficients.js'
 
 export interface AstroValue {
   value: number
-  speed: number | null
+  speed: number
 }
 
 export interface AstroData {
@@ -162,7 +162,7 @@ const astro = (time: Date): AstroData => {
   // in the more convenient unit of degrees per hour.
   const dTdHour = 1 / (24 * 365.25 * 100)
   Object.keys(polynomials).forEach((name) => {
-    (result as any)[name] = {
+    ;(result as any)[name] = {
       value: modulus(polynomial(polynomials[name], T(time)), 360.0),
       speed: derivativePolynomial(polynomials[name], T(time)) * dTdHour
     }

src/constituents/constituent.ts

@@ -30,7 +30,7 @@ const astronimicDoodsonNumber = (
 const astronomicSpeed = (astro: AstroData): number[] => {
   const results: number[] = []
   astronimicDoodsonNumber(astro).forEach((number) => {
-    results.push(number.speed!)
+    results.push(number.speed)
   })
   return results
 }

src/index.ts

@@ -38,21 +38,13 @@ export interface TidePrediction {
 
 const tidePredictionFactory = (
   constituents: HarmonicConstituent[],
-  options?: TidePredictionOptions
+  options: TidePredictionOptions = {}
 ): TidePrediction => {
   const harmonicsOptions = {
     harmonicConstituents: constituents,
     phaseKey: 'phase_GMT',
-    offset: false as number | false
-  }
-
-  if (typeof options !== 'undefined') {
-    Object.keys(harmonicsOptions).forEach((key) => {
-      if (typeof options[key as keyof TidePredictionOptions] !== 'undefined') {
-        (harmonicsOptions as any)[key] =
-          options[key as keyof TidePredictionOptions]
-      }
-    })
+    offset: false as number | false,
+    ...options
   }
 
   const tidePrediction: TidePrediction = {