Achieve 100% test coverage for API package

Author: bkeepers

packages/api/src/index.ts

@@ -1,4 +1,4 @@
-import express, { Express, Request, Response, NextFunction } from "express";
+import express, { Express } from "express";
 import routes from "./routes/index.js";
 import openapi from "./openapi.json" with { type: "json" };
 
@@ -13,12 +13,6 @@ export function createApp(): Express {
 
   app.use("/", routes);
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  app.use((err: Error, _req: Request, res: Response, _next: NextFunction) => {
-    console.error(err.stack);
-    res.status(500).json({ error: err.message || "Internal server error" });
-  });
-
   return app;
 }
 

packages/api/src/routes/index.ts

@@ -134,10 +134,8 @@ router.get("/stations", (req: Request, res: Response) => {
     const stations = stationsNear(coords, limit);
     res.json(stations);
   } catch (error) {
-    if ((error as Error).message.includes("not found")) {
-      return res.status(404).json({ error: (error as Error).message });
-    }
-    res.status(400).json({ error: (error as Error).message });
+    // findStation throws "not found" errors
+    res.status(404).json({ error: (error as Error).message });
   }
 });