Skip to content

Cover global/window events #1111

Open
Open
@Elchi3

Description

In #879 I re-enabled collecting compat data for events, but skipped those for global/window event handlers:

const skipIncludes = [
  "WindowOrWorkerGlobalScope", // handled separately as globals
  "GlobalEventHandlers", // XXX needs special handling
  "WindowEventHandlers", // XXX needs special handling
];

https://github.com/openwebdocs/mdn-bcd-collector/blob/9e556b0fdea227e5c9aa549e8bf4138dfe188fbd/test-builder/api.ts#L92C1-L96C9

To meet our coverage goal of 90% (see openwebdocs/project#161), we want to sort our coverage of events (the work on events will add coverage of ~175 more data entries)

The GlobalEventHandlers and WindowEventHandlers mixins are mixed into a lot of interfaces and we don't want the collector to add these to all of them. So likely a mapping will be needed. BCD already does that, but the mapping isn't scripted anywhere so there might be bugs with it, too. Mapping it here in the collector will likely help to ensure consistency. Then there is also bubbling and that might not be handled consistently yet either, so maybe we need even more mappings.

I volunteered to implement this. Wish me luck :)

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions