Skip to content

Commit de476b6

Browse files
pushpit kambojpushpit kamboj
authored andcommitted
[fix] Remove js env and edited permissions for workflow
1 parent 35c1c88 commit de476b6

2 files changed

Lines changed: 9 additions & 10 deletions

File tree

.github/workflows/bot-changelog-runner.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,19 @@ on:
88

99
permissions:
1010
actions: read
11-
contents: read
12-
pull-requests: write
13-
issues: write
14-
15-
env:
16-
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
1711

1812
jobs:
1913
fetch-metadata:
2014
runs-on: ubuntu-latest
2115
if: github.event.workflow_run.conclusion == 'success'
16+
permissions:
17+
actions: read
2218
outputs:
2319
pr_number: ${{ steps.metadata.outputs.pr_number }}
2420
steps:
2521
- name: Download PR metadata
2622
id: download
27-
uses: actions/download-artifact@v4
23+
uses: actions/download-artifact@v8
2824
with:
2925
name: changelog-metadata
3026
github-token: ${{ secrets.GITHUB_TOKEN }}
@@ -45,6 +41,10 @@ jobs:
4541
changelog:
4642
needs: fetch-metadata
4743
if: needs.fetch-metadata.outputs.pr_number != ''
44+
permissions:
45+
contents: read
46+
pull-requests: write
47+
issues: write
4848
uses: openwisp/openwisp-utils/.github/workflows/reusable-bot-changelog.yml@master
4949
with:
5050
pr_number: ${{ needs.fetch-metadata.outputs.pr_number }}

.github/workflows/bot-changelog-trigger.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ on:
44
pull_request_review:
55
types: [submitted]
66

7-
env:
8-
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
7+
permissions: {}
98

109
jobs:
1110
check:
@@ -33,7 +32,7 @@ jobs:
3332

3433
- name: Upload PR metadata
3534
if: steps.check.outputs.has_noteworthy == 'true'
36-
uses: actions/upload-artifact@v4
35+
uses: actions/upload-artifact@v7
3736
with:
3837
name: changelog-metadata
3938
path: pr_number

0 commit comments

Comments
 (0)