Skip to content

Commit 5d5e786

Browse files
Iishaan TanwarPRoIISHAAN
authored andcommitted
[change] Changed api to return reset attribute and updated tests
1 parent 9c11caa commit 5d5e786

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

openwisp_radius/api/serializers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ def get_reset(self, obj):
335335
group=self.context["group"],
336336
group_check=obj,
337337
)
338-
start_time, end_time = counter.get_reset_timestamps()
338+
_, end_time = counter.get_reset_timestamps()
339339
return end_time
340340
except (SkipCheck, ValueError, KeyError):
341341
return None

openwisp_radius/tests/test_api/test_api.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1070,6 +1070,7 @@ def test_user_group_check_serializer_counter_does_not_exist(self):
10701070
"result": None,
10711071
"type": None,
10721072
"value": "2000000000",
1073+
"reset": None,
10731074
},
10741075
)
10751076

@@ -1098,6 +1099,7 @@ def test_user_radius_usage_view(self):
10981099
"value": "10800",
10991100
"result": 0,
11001101
"type": "seconds",
1102+
"reset": checks[0]["reset"],
11011103
},
11021104
)
11031105
self.assertDictEqual(
@@ -1108,6 +1110,7 @@ def test_user_radius_usage_view(self):
11081110
"value": "3000000000",
11091111
"result": 0,
11101112
"type": "bytes",
1113+
"reset": checks[1]["reset"],
11111114
},
11121115
)
11131116

@@ -1139,6 +1142,7 @@ def test_user_radius_usage_view(self):
11391142
"value": "10800",
11401143
"result": 261,
11411144
"type": "seconds",
1145+
"reset": checks[0]["reset"],
11421146
},
11431147
)
11441148
self.assertDictEqual(
@@ -1149,6 +1153,7 @@ def test_user_radius_usage_view(self):
11491153
"value": "3000000000",
11501154
"result": 2000000000,
11511155
"type": "bytes",
1156+
"reset": checks[1]["reset"],
11521157
},
11531158
)
11541159

@@ -1177,6 +1182,7 @@ def test_user_radius_usage_view(self):
11771182
"value": "10800",
11781183
"result": 522,
11791184
"type": "seconds",
1185+
"reset": checks[0]["reset"],
11801186
},
11811187
)
11821188
self.assertDictEqual(
@@ -1187,6 +1193,7 @@ def test_user_radius_usage_view(self):
11871193
"value": "3000000000",
11881194
"result": 3000000000,
11891195
"type": "bytes",
1196+
"reset": checks[1]["reset"],
11901197
},
11911198
)
11921199

@@ -1215,6 +1222,7 @@ def test_user_radius_usage_view(self):
12151222
"value": "10800",
12161223
"result": 783,
12171224
"type": "seconds",
1225+
"reset": checks[0]["reset"],
12181226
},
12191227
)
12201228
self.assertDictEqual(
@@ -1225,6 +1233,7 @@ def test_user_radius_usage_view(self):
12251233
"value": "3000000000",
12261234
"result": 3000000000,
12271235
"type": "bytes",
1236+
"reset": checks[1]["reset"],
12281237
},
12291238
)
12301239

@@ -1251,6 +1260,7 @@ def test_user_group_check_serializer_counter_does_not_exist(self):
12511260
"result": None,
12521261
"type": None,
12531262
"value": "2000000000",
1263+
"reset": None,
12541264
},
12551265
)
12561266

0 commit comments

Comments
 (0)