[fix] Fixted tests

Author: pandafy

client/components/mobile-phone-change/mobile-phone-change.js

@@ -33,10 +33,21 @@ class MobilePhoneChange extends React.Component {
       phone_number: "",
       errors: {},
     };
+    this.isComponentMounted = true;
     this.handleSubmit = this.handleSubmit.bind(this);
     this.handleChange = this.handleChange.bind(this);
   }
 
+  setStateSafe(state, callback) {
+    if (this.isComponentMounted) {
+      this.setState(state, callback);
+    }
+  }
+
+  componentWillUnmount() {
+    this.isComponentMounted = false;
+  }
+
   async componentDidMount() {
     const {setLoading} = this.context;
     const {cookies, orgSlug, setUserData, logout, setTitle, orgName, language} =
@@ -55,9 +66,11 @@ class MobilePhoneChange extends React.Component {
     if (isValid) {
       ({userData} = this.props);
       const {phone_number} = userData;
-      this.setState({phone_number});
+      this.setStateSafe({phone_number});
+    }
+    if (this.isComponentMounted) {
+      setLoading(false);
     }
-    setLoading(false);
   }
 
   handleSubmit(event) {

client/components/mobile-phone-change/mobile-phone-change.test.js

@@ -423,16 +423,6 @@ describe("Change Phone Number: corner cases", () => {
     expect(wrapper.find(StatusMock)).toHaveLength(0);
   });
 
-  it("should redirect if user registration method is pending_verification", async () => {
-    validateToken.mockReturnValue(true);
-    props.userData = userData;
-    props.userData.is_active = true;
-    props.userData.method = "pending_verification";
-    props.settings.mobile_phone_verification = true;
-    wrapper = await mountComponent(props);
-    expect(wrapper.find(StatusMock)).toHaveLength(1);
-  });
-
   it("should validate token", async () => {
     wrapper = await mountComponent(props);
     expect(validateToken).toHaveBeenCalledWith(
@@ -444,6 +434,17 @@ describe("Change Phone Number: corner cases", () => {
       props.language,
     );
   });
+
+  it("should redirect if user registration method is pending_verification", async () => {
+    validateToken.mockReturnValue(true);
+    props.userData = userData;
+    props.userData.is_active = true;
+    props.userData.method = "pending_verification";
+    props.settings.mobile_phone_verification = true;
+    wrapper = await mountComponent(props);
+    expect(wrapper.find(StatusMock)).toHaveLength(1);
+  });
+
   it("should redirect if mobile_phone_verification disabled", async () => {
     props.settings.mobile_phone_verification = false;
     wrapper = await mountComponent(props);