Commit 57a1ee4
committed
Fix telemetry resource export by adding rt-tokio feature
Without the rt-tokio feature on opentelemetry_sdk, the BatchSpanProcessor
silently fails to export resource attributes (service.name, service.instance.id)
with traces. This is a poorly designed API that compiles without errors but
produces broken behavior at runtime.
Changes:
- Add rt-tokio feature to opentelemetry_sdk dependency
- Re-enable AdaptiveSpanProcessor for tail-based sampling
- Add comment explaining rt-tokio requirement
- Bump version to 0.13.4
The issue only affected traces; logs and metrics were unaffected because
they use different code paths (with_batch_exporter for logs works differently).1 parent 1284152 commit 57a1ee4
3 files changed
Lines changed: 6 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| 141 | + | |
141 | 142 | | |
142 | 143 | | |
143 | 144 | | |
| |||
0 commit comments