Skip to content

Commit a3702cd

Browse files
committed
fix(pre-commit): address pre-commit issues
1 parent fe55227 commit a3702cd

File tree

2 files changed

+19
-20
lines changed

2 files changed

+19
-20
lines changed

hide_commands/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
from .commands import (SetResolution, SetPosition)
1+
from .commands import SetPosition, SetResolution

hide_commands/commands.py

+18-19
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,23 @@
99
1010
"""
1111
import logging
12-
1312
from tkinter import ttk
1413

14+
from selenium.webdriver import Firefox
15+
1516
from openwpm.commands.types import BaseCommand
1617
from openwpm.config import BrowserParams, ManagerParams
1718
from openwpm.socket_interface import ClientSocket
1819

19-
from selenium.webdriver import Firefox
20-
2120

22-
def get_screen_resolution(driver):
21+
def get_screen_resolution(driver: Firefox) -> list[int]:
2322
return driver.execute_script("return [screen.width, screen.height];")
24-
23+
2524

2625
class SetResolution(BaseCommand):
27-
""" Sets the browser window resolution """
28-
def __init__(self, width, height) -> None:
26+
"""Sets the browser window resolution"""
27+
28+
def __init__(self, width: int, height: int) -> None:
2929
self.logger = logging.getLogger("openwpm")
3030
self.width = width
3131
self.height = height
@@ -39,22 +39,22 @@ def execute(
3939
browser_params: BrowserParams,
4040
manager_params: ManagerParams,
4141
extension_socket: ClientSocket,
42-
):
43-
42+
) -> None:
4443
self.logger.info(f"Setting window resolution to {self.width} x {self.height} ")
4544
driver.set_window_size(self.width, self.height)
46-
45+
4746
resolution = get_screen_resolution(driver)
4847
if resolution[0] <= self.width or resolution[1] <= self.height:
4948
self.logger.warn(
50-
f"Browser window resolution ({self.width} x {self.height}) exceeds " +
51-
f"screen resolution ({resolution[0]} x {resolution[1]})")
52-
53-
49+
f"Browser window resolution ({self.width} x {self.height}) exceeds "
50+
+ f"screen resolution ({resolution[0]} x {resolution[1]})"
51+
)
52+
5453

5554
class SetPosition(BaseCommand):
56-
""" Sets the browser window position """
57-
def __init__(self, x, y) -> None:
55+
"""Sets the browser window position"""
56+
57+
def __init__(self, x: int, y: int) -> None:
5858
self.logger = logging.getLogger("openwpm")
5959
self.x = x
6060
self.y = y
@@ -68,6 +68,5 @@ def execute(
6868
browser_params: BrowserParams,
6969
manager_params: ManagerParams,
7070
extension_socket: ClientSocket,
71-
):
72-
73-
driver.set_window_position(self.x, self.y, windowHandle='current')
71+
) -> None:
72+
driver.set_window_position(self.x, self.y, windowHandle="current")

0 commit comments

Comments
 (0)