Skip to content

Commit 1887dab

Browse files
ekayaaslancopybara-github
authored andcommitted
Push shardy inliner down out of shardy-import pipeline for early inliner.
It practically combines late and early inliner. PiperOrigin-RevId: 904960233
1 parent 8e6c383 commit 1887dab

4 files changed

Lines changed: 3 additions & 466 deletions

File tree

shardy/dialect/sdy/transforms/import/import_pipeline.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,6 @@ void addImportPipeline(OpPassManager& pm, int& dumpIndex,
5151
// constraints. This ensures we can detect sharding conflicts between group
5252
// members which have pre-propagation shardings due to sharding constraints.
5353
pm.addPass(createShardingGroupImportPass());
54-
if (!options.enableLateInlining) {
55-
pm.addPass(createImportFuncCallsPass());
56-
// Keep SymbolDCEPass after ImportFuncCallsPass.
57-
pm.addPass(createSymbolDCEPass());
58-
}
5954
}
6055

6156
void addImportPipeline(OpPassManager& pm, const PropagationOptions& options) {

shardy/dialect/sdy/transforms/import/test/import_pipeline_enable_late_inlining_false.mlir

Lines changed: 0 additions & 98 deletions
This file was deleted.

shardy/dialect/sdy/transforms/propagation/propagation_pipeline.cc

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,9 @@ void populateExportOptions(ExportOptions& options,
5454
void addPropagationPipeline(OpPassManager& pm, int& dumpIndex,
5555
const PropagationOptions& options) {
5656
addImportPipeline(pm, dumpIndex, options);
57-
if (options.enableLateInlining) {
58-
pm.addPass(createImportFuncCallsPass());
59-
// Keep SymbolDCEPass after ImportFuncCallsPass.
60-
pm.addPass(createSymbolDCEPass());
61-
}
57+
pm.addPass(createImportFuncCallsPass());
58+
// Keep SymbolDCEPass after ImportFuncCallsPass.
59+
pm.addPass(createSymbolDCEPass());
6260
{
6361
PropagationOptions optionsWithKeepShardingRules = options;
6462
optionsWithKeepShardingRules.keepShardingRules = true;

0 commit comments

Comments
 (0)