Skip to content

Commit 21c4415

Browse files
ekayaaslancopybara-github
authored andcommitted
Push shardy inliner down past ShardingGroupImport pass for late inlining.
ShardingGroupImport walks on sharding groups and verifies the groupings and simplifies their group numbers and erases duplicates. The pass does not do anything specific for ShardableDataFlowOps generally neither for NamedComputationOps specifically. Inlining and not-inlining should not impact the pass. PiperOrigin-RevId: 902624938
1 parent 2f59eb0 commit 21c4415

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

shardy/dialect/sdy/transforms/import/import_pipeline.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@ void addImportPipeline(OpPassManager& pm, int& dumpIndex,
5353
pm.addPass(
5454
createApplyShardingConstraintsPass(ApplyShardingConstraintsPassOptions{
5555
options.debugShardingOrigins, options.debugPropagationEdgeSharding}));
56+
// The sharding group import pass must run after applying sharding
57+
// constraints. This ensures we can detect sharding conflicts between group
58+
// members which have pre-propagation shardings due to sharding constraints.
59+
pm.addPass(createShardingGroupImportPass());
5660
if (options.enableLateInlining) {
5761
pm.addPass(createImportFuncCallsPass());
5862
// Keep SymbolDCEPass after ImportFuncCallsPass.
5963
pm.addPass(createSymbolDCEPass());
6064
}
61-
// The sharding group import pass must run after applying sharding
62-
// constraints. This ensures we can detect sharding conflicts between group
63-
// members which have pre-propagation shardings due to sharding constraints.
64-
pm.addPass(createShardingGroupImportPass());
6565
}
6666

6767
void addImportPipeline(OpPassManager& pm, const PropagationOptions& options) {

0 commit comments

Comments
 (0)