Skip to content

Commit c6a42b2

Browse files
ekayaaslancopybara-github
authored andcommitted
Push shardy inliner down past ApplyShardingConstraints pass for early inliner.
PiperOrigin-RevId: 904958581
1 parent ab66b49 commit c6a42b2

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

shardy/dialect/sdy/transforms/import/import_pipeline.cc

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,6 @@ void addImportPipeline(OpPassManager& pm, int& dumpIndex,
3232
pm.addPass(createRemoveSizeOneAxesPass());
3333
pm.addPass(createPropagateShardingFromFuncToCallPass());
3434
pm.addPass(createConstantOrScalarSplitterPass());
35-
if (!options.enableLateInlining) {
36-
pm.addPass(createImportFuncCallsPass(ImportFuncCallsPassOptions{
37-
/*addDataFlowEdgesOnNamedComputations=*/false}));
38-
// Keep SymbolDCEPass after ImportFuncCallsPass.
39-
pm.addPass(createSymbolDCEPass());
40-
}
4135
pm.addPass(createSymbolDCEPass());
4236
pm.addPass(createManualAxesCleanupPass());
4337

@@ -53,6 +47,11 @@ void addImportPipeline(OpPassManager& pm, int& dumpIndex,
5347
pm.addPass(
5448
createApplyShardingConstraintsPass(ApplyShardingConstraintsPassOptions{
5549
options.debugShardingOrigins, options.debugPropagationEdgeSharding}));
50+
if (!options.enableLateInlining) {
51+
pm.addPass(createImportFuncCallsPass());
52+
// Keep SymbolDCEPass after ImportFuncCallsPass.
53+
pm.addPass(createSymbolDCEPass());
54+
}
5655
// The sharding group import pass must run after applying sharding
5756
// constraints. This ensures we can detect sharding conflicts between group
5857
// members which have pre-propagation shardings due to sharding constraints.

0 commit comments

Comments
 (0)