Skip to content

Commit 954adce

Browse files
Update TODOs in XLA to reference bug numbers.
This change replaces TODOs associated with me with references to tracking bugs for better management. One obsolete TODO in scatter.cc is also removed. PiperOrigin-RevId: 900788150
1 parent 147ce73 commit 954adce

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

xla/backends/gpu/codegen/emitters/scatter.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,6 @@ void ScatterWithDistributedIndices::ComputeIndexing(
601601
}
602602

603603
if (updates_map) {
604-
// TODO (karupayun): Check number of dimensions.
605604
auto index_id = CreateSymbolExpr(0, kGpuGridDims, mlir_context);
606605
auto update_dim_loop = CreateSymbolExpr(1, kGpuGridDims, mlir_context);
607606
auto vector_id = CreateSymbolExpr(2, kGpuGridDims, mlir_context);

xla/hlo/analysis/indexing_map_serialization.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -899,7 +899,7 @@ std::string ToString(const IndexingMap& indexing_map,
899899
symbol_names.reserve(range_names.size() + rt_names.size());
900900
symbol_names.append(range_names.begin(), range_names.end());
901901
symbol_names.append(rt_names.begin(), rt_names.end());
902-
// TODO(karupayun): Do not use conversion here.
902+
// TODO(b/446856305): Do not use conversion here.
903903
ss << ToString(SymbolicMapToAffineMap(indexing_map.GetSymbolicMap()),
904904
dim_names, range_names, rt_names);
905905
if (dim_vars.empty() && range_vars.empty() && rt_vars.empty()) {

xla/hlo/analysis/indexing_map_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,7 @@ TEST_F(IndexingMapTest, ConstraintIntervalSimplification_Sum) {
621621
d0 mod 8 + 5 in [50, 54]
622622
)");
623623
EXPECT_TRUE(indexing_map.Simplify());
624-
// TODO(karupayun): This should be infeasible, since d0 mod 8 should be in
624+
// TODO: b/459357586 - This should be infeasible, since d0 mod 8 should be in
625625
// [0, 7].
626626
EXPECT_THAT(ToString(indexing_map), MatchIndexingString(R"(
627627
(d0) -> (d0),
@@ -678,7 +678,7 @@ TEST_F(IndexingMapTest,
678678
s1 in [0, 2],
679679
d0 * 6 + s0 * 3 + s1 in [0, 598]
680680
)");
681-
// TODO(karupayun): This should be simplified to
681+
// TODO: b/459357586 - This should be simplified to
682682
// (d0)[s0, s1] -> (d0 * 6 + s0 * 3 + s1),
683683
// domain:
684684
// d0 in [0, 99],

xla/hlo/analysis/symbolic_expr.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ enum class SymbolicExprType {
4747
kMin,
4848
kVariable,
4949
kConstant, // Constant should be the last type for the comparator.
50-
// TODO(karupayun): Add kIn operator.
50+
// TODO: b/459357586 - Add kIn operator.
5151
// kIn, // 'var in [a, b]' .
5252
};
5353

0 commit comments

Comments
 (0)