fix: bug of yurtappset always the last tweaks make effect (#2243)

github-actions[bot] · vie-serendipity · web-flow · commit 67618e02f0b8 · 2025-01-04T21:01:12.000+08:00
Signed-off-by: vie-serendipity <2733147505@qq.com> (cherry picked from commit b099092) Co-authored-by: vie-serendipity <2733147505@qq.com>
diff --git a/pkg/yurtmanager/controller/yurtappset/workloadmanager/tweaks.go b/pkg/yurtmanager/controller/yurtappset/workloadmanager/tweaks.go
@@ -42,7 +42,8 @@ func GetNodePoolTweaksFromYurtAppSet(cli client.Client, nodepoolName string, yas
 	for _, yasTweak := range yas.Spec.Workload.WorkloadTweaks {
 		if isNodePoolRelated(&np, yasTweak.Pools, yasTweak.NodePoolSelector) {
 			klog.V(4).Infof("nodepool %s is related to yurtappset %s/%s, add tweaks", nodepoolName, yas.Namespace, yas.Name)
-			tweaksList = append(tweaksList, &yasTweak.Tweaks)
+			tweaksCopy := yasTweak.Tweaks
+			tweaksList = append(tweaksList, &tweaksCopy)
 		}
 	}
 	return

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,8 @@ func GetNodePoolTweaksFromYurtAppSet(cli client.Client, nodepoolName string, yas`
`42`	`42`	`for _, yasTweak := range yas.Spec.Workload.WorkloadTweaks {`
`43`	`43`	`if isNodePoolRelated(&np, yasTweak.Pools, yasTweak.NodePoolSelector) {`
`44`	`44`	`klog.V(4).Infof("nodepool %s is related to yurtappset %s/%s, add tweaks", nodepoolName, yas.Namespace, yas.Name)`
`45`		`- tweaksList = append(tweaksList, &yasTweak.Tweaks)`
	`45`	`+ tweaksCopy := yasTweak.Tweaks`
	`46`	`+ tweaksList = append(tweaksList, &tweaksCopy)`
`46`	`47`	`}`
`47`	`48`	`}`
`48`	`49`	`return`