zpool import -c -d and -s options

[AttilaFueloep]

Question

Should we make the -d /dir[/device] and -s options of zpool import mutually exclusive as it's already done with -c?

Rational

Since the -d /dir[/device] option always overrides the -s option and ZPOOL_IMPORT_PATH=/dir zpool import -s is just another way of saying zpool import -d /dir, -d and -s shouldn't be allowed together. (Unless I'm overlooking something of course.)

# mkdir /tmp/A /tmp/B
# truncate -s64M /tmp/A/d1 /tmp/B/d1
# zpool create A /tmp/A/d1
# zpool create B /tmp/B/d1
# zpool export A B
# ZPOOL_IMPORT_PATH=/tmp/A zpool import -s
   pool: A
     id: 8907771379885165334
  state: ONLINE
 action: The pool can be imported using its name or numeric identifier.
 config:

	A            ONLINE
	  /tmp/A/d1  ONLINE
# ZPOOL_IMPORT_PATH=/tmp/A zpool import -s -d /tmp/B
   pool: B
     id: 3788372684671344976
  state: ONLINE
 action: The pool can be imported using its name or numeric identifier.
 config:

	B            ONLINE
	  /tmp/B/d1  ONLINE

Just stumbled upon this while updating the zpool man pages and usage messages (more on this later).

Will open a PR if agreement is met.

[AttilaFueloep]

Answering myself, looking at the code -d seems to imply the "skip the blkid cache" part of -s but ignores the default search patch (as expected). So I'd say it's OK to make them mutually exclusive to avoid confusion. Thoughts?