Skip to content

Commit 2fda929

Browse files
committed
fix(express): fixes typing for express middleware.
1 parent b3b5a0c commit 2fda929

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

packages/zipkin-instrumentation-express/index.d.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ import {Tracer} from 'zipkin';
1111
* Note that if the next middleware makes async calls, it should either
1212
* store the span id manually or use a CLSContext so that the annotations
1313
* go to the correct spans
14+
*
15+
* @param {Object} options
16+
* @property {Tracer} options.tracer
17+
* @property {number} options.port
1418
*/
1519
export declare function expressMiddleware(
1620
options: {tracer: Tracer, port?: number}

packages/zipkin-instrumentation-express/src/expressMiddleware.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function formatRequestUrl(req) {
1919
/**
2020
* @typedef {Object} MiddlewareOptions
2121
* @property {Object} tracer
22-
* @property {string} serviceName
22+
* @property {string} serviceName @deprecated use the localEndpoint in Tracer instead
2323
* @property {number} port
2424
*/
2525

0 commit comments

Comments
 (0)