Skip to content

Commit 5983bd9

Browse files
Remove outdated BOM warning from dependencyManagement (#3826)
flattenMode=ossrh strips dependencyManagement from published poms, so end users never inherit BOMs declared here. See: https://github.com/mojohaus/flatten-maven-plugin/blob/master/src/main/java/org/codehaus/mojo/flatten/FlattenMode.java Signed-off-by: Adrian Cole <adrian@tetrate.io> Signed-off-by: Adrian Cole <adrian@tetrate.io>
1 parent fae3ec2 commit 5983bd9

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

pom.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -162,14 +162,6 @@
162162
<url>https://github.com/openzipkin/zipkin/issues</url>
163163
</issueManagement>
164164

165-
<dependencyManagement>
166-
<!-- Be careful here, especially to not import BOMs as io.zipkin.zipkin2:zipkin has this parent.
167-
168-
For example, if you imported Netty's BOM here, using Brave would also download that BOM as
169-
it depends indirectly on io.zipkin.zipkin2:zipkin. As Brave itself is indirectly used, this
170-
can be extremely confusing when people are troubleshooting library version assignments. -->
171-
</dependencyManagement>
172-
173165
<dependencies>
174166
<!-- Do not add compile dependencies here. This can cause problems for libraries that depend on
175167
io.zipkin.zipkin2:zipkin difficult to unravel. -->

0 commit comments

Comments
 (0)