Merge pull request #846 from openziti/service-router-leak

ekoby · web-flow · commit da00ae9f3cd5 · 2025-04-01T16:35:15.000-04:00
fix memory leak in handling of service routers
diff --git a/library/bind.c b/library/bind.c
@@ -268,8 +268,9 @@ static void list_routers_cb(ziti_service_routers *srv_routers, const ziti_error
             CONN_LOG(DEBUG, "%s/%s", er->name, er->protocols.tls);
             model_list_append(&conn->server.routers, er);
         }
+        FREE(srv_routers->routers); // router objects moved to the list
     }
-    free(srv_routers);
+    free_ziti_service_routers_ptr(srv_routers);
 
     if (conn->server.token != NULL) {
         process_bindings(conn);

Original file line number	Diff line number	Diff line change
`@@ -268,8 +268,9 @@ static void list_routers_cb(ziti_service_routers *srv_routers, const ziti_error`
`268`	`268`	`CONN_LOG(DEBUG, "%s/%s", er->name, er->protocols.tls);`
`269`	`269`	`model_list_append(&conn->server.routers, er);`
`270`	`270`	`}`
	`271`	`+ FREE(srv_routers->routers); // router objects moved to the list`
`271`	`272`	`}`
`272`		`- free(srv_routers);`
	`273`	`+ free_ziti_service_routers_ptr(srv_routers);`
`273`	`274`
`274`	`275`	`if (conn->server.token != NULL) {`
`275`	`276`	`process_bindings(conn);`