Merge pull request #850 from openziti/ctrl-detail-missing-edge-v1

fix crash if ctrl detail missing edge version

Author: ekoby

.github/workflows/build-release.yml

@@ -18,9 +18,9 @@ jobs:
       fail-fast: false
       matrix:
         spec:
-          - { name: 'Linux x86_64', runner: 'ubuntu-20.04', target: 'linux-x64', builder: 'openziti/ziti-builder:v2' }
-          - { name: 'Linux ARM', runner: 'ubuntu-20.04', target: 'linux-arm', builder: 'openziti/ziti-builder:v2' }
-          - { name: 'Linux ARM64', runner: 'ubuntu-20.04', target: 'linux-arm64', builder: 'openziti/ziti-builder:v2' }
+          - { name: 'Linux x86_64', runner: 'ubuntu-latest', target: 'linux-x64', builder: 'openziti/ziti-builder:v2' }
+          - { name: 'Linux ARM', runner: 'ubuntu-latest', target: 'linux-arm', builder: 'openziti/ziti-builder:v2' }
+          - { name: 'Linux ARM64', runner: 'ubuntu-latest', target: 'linux-arm64', builder: 'openziti/ziti-builder:v2' }
           - { name: 'MacOS x86_64', runner: 'macOS-13', target: 'macOS-x64' }
           - { name: 'MacOS arm64', runner: 'macOS-14', target: 'macOS-arm64' }
           - { name: 'Windows x86_64', runner: 'windows-2022', target: 'windows-x64' }

.github/workflows/cmake.yml

@@ -25,9 +25,9 @@ jobs:
       fail-fast: false
       matrix:
         spec:
-          - { name: 'Linux x86_64', runner: 'ubuntu-20.04', target: 'linux-x64', builder: 'openziti/ziti-builder:v2', test: 'true' }
-          - { name: 'Linux ARM', runner: 'ubuntu-20.04', target: 'linux-arm', builder: 'openziti/ziti-builder:v2' }
-          - { name: 'Linux ARM64', runner: 'ubuntu-20.04', target: 'linux-arm64', builder: 'openziti/ziti-builder:v2' }
+          - { name: 'Linux x86_64', runner: 'ubuntu-latest', target: 'linux-x64', builder: 'openziti/ziti-builder:v2', test: 'true' }
+          - { name: 'Linux ARM', runner: 'ubuntu-latest', target: 'linux-arm', builder: 'openziti/ziti-builder:v2' }
+          - { name: 'Linux ARM64', runner: 'ubuntu-latest', target: 'linux-arm64', builder: 'openziti/ziti-builder:v2' }
           - { name: 'MacOS x86_64', runner: 'macOS-13', target: 'macOS-x64', test: 'true' }
           - { name: 'MacOS arm64', runner: 'macOS-14', target: 'macOS-arm64', test: 'true' }
           - { name: 'Windows x86_64', runner: 'windows-2022', target: 'windows-x64', test: 'true' }

library/ziti_ctrl.c

@@ -293,7 +293,7 @@ static void internal_ctrl_list_cb(ziti_controller_detail_array arr, const ziti_e
         api_address *addr = NULL;
         MODEL_LIST_FOREACH(addr, d->apis.edge) {
             CTRL_LOG(VERBOSE, "%s/%s", addr->version, addr->url);
-            if (strcmp(addr->version, "v1") == 0) {
+            if (addr->version && strcmp(addr->version, "v1") == 0) {
                 break;
             }
             addr = NULL;
@@ -309,6 +309,7 @@ static void internal_ctrl_list_cb(ziti_controller_detail_array arr, const ziti_e
                 change = change || (old_detail->is_online != d->is_online);
             }
         } else {
+            CTRL_LOG(DEBUG, "ctrl[%s] has no edge/v1 endpoint", d->name);
             free_ziti_controller_detail_ptr(d);
         }
     }