Fix Multiple Cookie Issue: Properly Handle Multiple Set-Cookie Headers in ZitiUrlProtocol#283
Conversation
scareything
left a comment
There was a problem hiding this comment.
Hi and thanks for the PR! It looks good to me. Can you please sign a contributor license agreement if you haven't already?
Hi! Thanks a lot for checking it out 😊 Let me know if there’s anything else I should do 🙌 |
Hey, thanks for the reminder! Let me know if there’s anything else you need! |
|
Thanks for the cla. We have it. I just noticed that your commit on this PR is not signed, and we require signed commits. Could you please set up commit signing described here and amend your existing commit, then force-push? |
Hi there, thanks for the heads‑up! I’ll configure commit signing as described, amend the existing commit with a GPG signature, and force‑push the branch shortly. Let me know if you need anything else! |
d47366d to
ee50cd5
Compare
|
Hi. I see that the commit is now signed, Thanks! I'm guessing the changes in Thanks. |
…o handle multiple Set-Cookie headers. Collect all Set-Cookie values into a single entry in the resulting dictionary.
ee50cd5 to
269aead
Compare
Hi @scareything, sorry about that! I accidentally included changes to deps/ – I’ve reset those files and force‑pushed the branch. Build should be back to green now. Please let me know if you spot anything else. Thanks! |
This PR addresses an issue where multiple
Set-Cookieheaders in HTTP responses were not handled correctly byZitiUrlProtocol. Previously, only one cookie would be processed, causing potential loss of additional cookies set by the server.Key improvements:
Set-Cookieheaders from HTTP responses.This fix improves compatibility with servers that set multiple cookies and ensures more reliable client behavior.
Please review and let me know if further changes are needed. Thank you!