Migrate away from ioutil

Signed-off-by: Per Goncalves da Silva <[email protected]>

Author: Per Goncalves da Silva

pkg/manifests/bundleloader.go

@@ -2,7 +2,6 @@ package manifests
 
 import (
 	"fmt"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"strings"
@@ -189,7 +188,7 @@ func (b *bundleLoader) LoadBundleWalkFunc(path string, f os.FileInfo, err error)
 // loadBundle takes the directory that a CSV is in and assumes the rest of the objects in that directory
 // are part of the bundle.
 func loadBundle(csvName string, dir string) (*Bundle, error) {
-	files, err := ioutil.ReadDir(dir)
+	files, err := os.ReadDir(dir)
 	if err != nil {
 		return nil, err
 	}

pkg/validation/internal/community.go

@@ -3,7 +3,6 @@ package internal
 import (
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
 	"os"
 	"strings"
 
@@ -225,7 +224,7 @@ func validateImageFile(checks CommunityOperatorChecks, deprecatedAPImsg string)
 		return checks
 	}
 
-	b, err := ioutil.ReadFile(checks.indexImagePath)
+	b, err := os.ReadFile(checks.indexImagePath)
 	if err != nil {
 		checks.errs = append(checks.errs, fmt.Errorf("unable to read the index image in the path "+
 			"(%s). Error : %s", checks.indexImagePath, err))

pkg/validation/internal/crd_test.go

@@ -1,7 +1,7 @@
 package internal
 
 import (
-	"io/ioutil"
+	"os"
 	"testing"
 
 	"github.com/operator-framework/api/pkg/validation/errors"
@@ -57,7 +57,7 @@ func TestValidateCRD(t *testing.T) {
 		},
 	}
 	for _, tt := range table {
-		b, err := ioutil.ReadFile(tt.filePath)
+		b, err := os.ReadFile(tt.filePath)
 		if err != nil {
 			t.Fatalf("Error reading CRD path %s: %v", tt.filePath, err)
 		}

pkg/validation/internal/csv_test.go

@@ -2,7 +2,7 @@ package internal
 
 import (
 	"fmt"
-	"io/ioutil"
+	"os"
 	"path/filepath"
 	"testing"
 
@@ -121,7 +121,7 @@ func TestValidateCSV(t *testing.T) {
 	}
 
 	for _, c := range cases {
-		b, err := ioutil.ReadFile(c.csvPath)
+		b, err := os.ReadFile(c.csvPath)
 		if err != nil {
 			t.Fatalf("Error reading CSV path %s: %v", c.csvPath, err)
 		}

pkg/validation/internal/object_test.go

@@ -1,7 +1,7 @@
 package internal
 
 import (
-	"io/ioutil"
+	"os"
 	"testing"
 
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
@@ -66,7 +66,7 @@ func TestValidateObject(t *testing.T) {
 
 	for _, tt := range table {
 		u := unstructured.Unstructured{}
-		o, err := ioutil.ReadFile(tt.path)
+		o, err := os.ReadFile(tt.path)
 		if err != nil {
 			t.Fatalf("reading yaml object file: %s", err)
 		}

pkg/validation/internal/operatorgroup_test.go

@@ -1,7 +1,7 @@
 package internal
 
 import (
-	"io/ioutil"
+	"os"
 	"path/filepath"
 	"testing"
 
@@ -33,7 +33,7 @@ func TestValidateOperatorGroup(t *testing.T) {
 		},
 	}
 	for _, c := range cases {
-		b, err := ioutil.ReadFile(c.operatorGroupPath)
+		b, err := os.ReadFile(c.operatorGroupPath)
 		if err != nil {
 			t.Fatalf("Error reading OperatorGroup path %s: %v", c.operatorGroupPath, err)
 		}

pkg/validation/internal/operatorhub.go

@@ -3,9 +3,9 @@ package internal
 import (
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
 	"net/mail"
 	"net/url"
+	"os"
 	"path/filepath"
 	"strings"
 
@@ -313,7 +313,7 @@ func extractCategories(path string) (map[string]struct{}, error) {
 		return nil, fmt.Errorf("finding category file: %w", err)
 	}
 
-	data, err := ioutil.ReadFile(path)
+	data, err := os.ReadFile(path)
 	if err != nil {
 		return nil, fmt.Errorf("reading category file: %w", err)
 	}