Skip to content

Commit c471e97

Browse files
committed
Add a comment that unlabeled CR might be reonciled
1 parent 9149213 commit c471e97

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

pkg/reconciler/reconciler_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1584,6 +1584,9 @@ var _ = Describe("Reconciler", func() {
15841584
Expect(mgr.GetClient().Create(ctx, anotherObj)).To(Succeed())
15851585
})
15861586

1587+
// There is no robust way to check whether controller-runtime will never do something.
1588+
// So there is a low chance that the unlabeled CR could be reconciled.
1589+
// See: https://kubernetes.slack.com/archives/C02MRBMN00Z/p1762251589740719
15871590
By("verifying that the labeled reconciler does not reconcile CR without labels", func() {
15881591
Consistently(func() bool {
15891592
mu.Lock()

0 commit comments

Comments
 (0)