add tests to increase test coverage

Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>

Author: rashmigottipati

internal/operator-controller/bundleutil/bundle_test.go

@@ -290,3 +290,52 @@ func TestMetadataFor(t *testing.T) {
 		})
 	})
 }
+
+func TestGetVersionAndRelease_Errors(t *testing.T) {
+	t.Run("invalid JSON for release field detection", func(t *testing.T) {
+		// Enable gate for this test
+		prevEnabled := features.OperatorControllerFeatureGate.Enabled(features.BundleReleaseSupport)
+		require.NoError(t, features.OperatorControllerFeatureGate.Set("BundleReleaseSupport=true"))
+		t.Cleanup(func() {
+			require.NoError(t, features.OperatorControllerFeatureGate.Set(fmt.Sprintf("BundleReleaseSupport=%t", prevEnabled)))
+		})
+
+		// Malformed JSON that can't be unmarshalled for release detection
+		bundle := declcfg.Bundle{
+			Name: "test-bundle",
+			Properties: []property.Property{
+				{
+					Type:  property.TypePackage,
+					Value: json.RawMessage(`{"version": "1.0.0", "release": invalid}`),
+				},
+			},
+		}
+
+		_, err := bundleutil.GetVersionAndRelease(bundle)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "error unmarshalling package")
+	})
+
+	t.Run("invalid version in explicit release path", func(t *testing.T) {
+		// Enable gate for this test
+		prevEnabled := features.OperatorControllerFeatureGate.Enabled(features.BundleReleaseSupport)
+		require.NoError(t, features.OperatorControllerFeatureGate.Set("BundleReleaseSupport=true"))
+		t.Cleanup(func() {
+			require.NoError(t, features.OperatorControllerFeatureGate.Set(fmt.Sprintf("BundleReleaseSupport=%t", prevEnabled)))
+		})
+
+		bundle := declcfg.Bundle{
+			Name: "test-bundle",
+			Properties: []property.Property{
+				{
+					Type:  property.TypePackage,
+					Value: json.RawMessage(`{"version": "not-a-version", "release": "1"}`),
+				},
+			},
+		}
+
+		_, err := bundleutil.GetVersionAndRelease(bundle)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "error parsing version")
+	})
+}

internal/operator-controller/catalogmetadata/filter/successors_test.go

@@ -272,3 +272,52 @@ func TestLegacySuccessor(t *testing.T) {
 	assert.True(t, f(b5))
 	assert.False(t, f(emptyBundle))
 }
+
+func stringPtr(s string) *string {
+	return &s
+}
+
+func TestParseInstalledBundleVersionRelease_Errors(t *testing.T) {
+	t.Run("invalid version - legacy format", func(t *testing.T) {
+		installedBundle := ocv1.BundleMetadata{
+			Name:    "test",
+			Version: "invalid-version",
+		}
+		_, err := parseInstalledBundleVersionRelease(installedBundle)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "failed to get version and release")
+	})
+
+	t.Run("invalid version - explicit release format", func(t *testing.T) {
+		installedBundle := ocv1.BundleMetadata{
+			Name:    "test",
+			Version: "invalid-version",
+			Release: stringPtr("1"),
+		}
+		_, err := parseInstalledBundleVersionRelease(installedBundle)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "failed to parse installed bundle version")
+	})
+
+	t.Run("invalid release - explicit release format", func(t *testing.T) {
+		installedBundle := ocv1.BundleMetadata{
+			Name:    "test",
+			Version: "1.0.0",
+			Release: stringPtr("001"),
+		}
+		_, err := parseInstalledBundleVersionRelease(installedBundle)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "failed to parse installed bundle release")
+	})
+}
+
+func TestSuccessorsOf_Errors(t *testing.T) {
+	t.Run("invalid installed bundle version", func(t *testing.T) {
+		installedBundle := ocv1.BundleMetadata{
+			Name:    "test",
+			Version: "invalid",
+		}
+		_, err := SuccessorsOf(installedBundle)
+		require.Error(t, err)
+	})
+}