-
Notifications
You must be signed in to change notification settings - Fork 567
OCPBUGS-65867: add config map service account to unpack jobs #3732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-65867: add config map service account to unpack jobs #3732
Conversation
|
Hi @ehearne-redhat. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @ankitathomas @grokspawn - could you mark this WIP PR as |
|
/ok-to-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oceanc80
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
60221e6
into
operator-framework:master
Description of the change:
A service account has been added to the unpack jobs.
Motivation for the change:
Using a default service account is not best practice. Part of efforts in OCPSTRAT-2401 .
Architectural changes:
Each unpack job will now use a bespoke service account. The service account is created by referencing the given config map's name and namespace.
Testing remarks:
Tests are passing locally. I modified unpacker job tests so they do not use default service account in testing.
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue