Improve error message for all namespaces

Mikalai Radchuk · m1kola · commit b5e34280dc14 · 2024-06-12T13:34:33.000Z
Signed-off-by: Mikalai Radchuk &lt;mradchuk@redhat.com&gt;
diff --git a/pkg/convert/registryv1.go b/pkg/convert/registryv1.go
@@ -148,6 +148,7 @@ func validateTargetNamespaces(supportedInstallModes sets.Set[string], installNam
 		if supportedInstallModes.Has(string(v1alpha1.InstallModeTypeAllNamespaces)) {
 			return nil
 		}
+		return fmt.Errorf("supported install modes %v do not support targeting all namespaces", sets.List(supportedInstallModes))
 	case set.Len() == 1 && !set.Has(""):
 		if supportedInstallModes.Has(string(v1alpha1.InstallModeTypeSingleNamespace)) {
 			return nil

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,7 @@ func validateTargetNamespaces(supportedInstallModes sets.Set[string], installNam`
`148`	`148`	`if supportedInstallModes.Has(string(v1alpha1.InstallModeTypeAllNamespaces)) {`
`149`	`149`	`return nil`
`150`	`150`	`}`
	`151`	`+ return fmt.Errorf("supported install modes %v do not support targeting all namespaces", sets.List(supportedInstallModes))`
`151`	`152`	`case set.Len() == 1 && !set.Has(""):`
`152`	`153`	`if supportedInstallModes.Has(string(v1alpha1.InstallModeTypeSingleNamespace)) {`
`153`	`154`	`return nil`