Merge pull request #1 from operators-rb/refactoring

refactoring

Author: Kirill Shevchenko

README.md

@@ -1,8 +1,14 @@
 # Operators::Service
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/operators/service`. To experiment with that code, run `bin/console` for an interactive prompt.
+Operators::Service is a lightweight implementation of Service Object based on Either Monad. That gives an home of application business logic.
 
-TODO: Delete this and the text above, and describe your gem
+Service Objects are created when an action:
+
+* Uses integration with external services
+
+* Uses several models
+
+* Is complex (such as calculating sales statistics)
 
 ## Installation
 
@@ -32,7 +38,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/operators-service.
+Bug reports and pull requests are welcome on GitHub at https://github.com/operators-rb/operators-service.
 
 
 ## License

Rakefile

@@ -1,2 +1,2 @@
-require "bundler/gem_tasks"
-task :default => :spec
+require 'bundler/gem_tasks'
+task default: :spec

lib/operators-service.rb

@@ -0,0 +1,2 @@
+require 'dry-monads'
+require 'operators/service'

lib/operators/service.rb

@@ -1,5 +1,3 @@
-require 'dry-monads'
-
 module Operators
   class Service
     def self.rescue_callbacks(*exceptions)
@@ -37,7 +35,7 @@ def success_wrap(result)
     end
 
     def calling
-      raise 'Must be redefined'
+      raise 'Not implemented'
     end
   end
 end

lib/operators_service.rb

@@ -1,15 +1,16 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'operators-service'
-  spec.version       = '0.1.1'
+  spec.version       = '0.2.0'
   spec.authors       = ['Yaroslav Bezrukavyi', 'Kirill Shevchenko']
   spec.email         = ['yaroslav.bezrukavyi@gmail.com', 'hello@kirillshevch.com']
 
   spec.summary       = 'You will always know the type of the result'
-  spec.description   = 'Service is based on Dry::Monads'
+  spec.description   = 'Service Object is based on Either Monad'
   spec.homepage      = 'http://operators-rb.org'
   spec.license       = 'MIT'
 
@@ -20,7 +21,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'dry-monads', '~> 0.3.1'
 
-  spec.add_development_dependency 'bundler', '~> 1.15.4'
+  spec.add_development_dependency 'bundler', '~> 1.14'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'byebug', '~> 3.5.0'

operators-service.gemspec

@@ -1,6 +1,6 @@
-RSpec.describe Operators::Service do
+describe Operators::Service do
   before do
-    class TestSerivce < Operators::Service
+    class TestService < Operators::Service
       rescue_callbacks SyntaxError
 
       def initialize(data, result)
@@ -19,17 +19,17 @@ def except_error(error)
   end
 
   it 'success result' do
-    result = TestSerivce.call('data', true)
+    result = TestService.call('data', true)
     expect(result.success?).to be_truthy
   end
 
   it 'failure result' do
-    result = TestSerivce.call('data', false)
+    result = TestService.call('data', false)
     expect(result.success?).to be_falsey
   end
 
   context 'catch error' do
-    subject { TestSerivce.new('error', true) }
+    subject { TestService.new('error', true) }
 
     it 'catch' do
       allow(subject).to receive(:calling).and_raise(SyntaxError)

spec/operators/service_spec.rb

@@ -1,6 +1,6 @@
 require 'bundler/setup'
 require 'byebug'
-require 'operators/service'
+require 'operators-service'
 
 RSpec.configure do |config|
   config.order = :random