[OP-19964] Fix 500 when creating a meeting outcome with an invalid kind (#24771)

* Fix 500 when creating a meeting outcome with an invalid kind

MeetingOutcome's kind enum was declared without validate: true, so
assigning an unrecognized value raised a raw Rails ArgumentError
instead of a normal ActiveModel validation error, propagating uncaught
through the API endpoint as a 500.

Add validate: true to the enum declaration -- Rails then rejects an
out-of-enum value through the usual validation path, returning a clean
422.

* Add missing MeetingOutcome#kind locale entry

CI's Units + Features job caught this live: the earlier fix in this PR
(validate: true on the kind enum) means Rails now builds a real
ActiveModel error message on an invalid kind, which needs
human_attribute_name for the attribute -- a key that never existed for
MeetingOutcome. Without it, the 422 path itself crashed with
I18n::MissingTranslationData instead of returning the intended
validation error. Verified live: before this entry, requesting
'activerecord.attributes.meeting_outcome.kind' raised; after, it
resolves to "Kind" and the full validation message reads "Kind is not
set to one of the allowed values."

* Refactor meeting_section localization entries

Removed duplicate meeting_section entries and adjusted presenter position.

* Fix missing keys

* Drop regression-test comment restating the PR description; fix stray trailing whitespace

The trailing whitespace after "Title" was an unrelated artifact of the
original diff's line touch.

---------

Co-authored-by: Oliver Günther <o.guenther@openproject.com>
Co-authored-by: Oliver Günther <mail@oliverguenther.de>

Author: jtauschl

modules/meeting/app/models/meeting_outcome.rb

@@ -36,7 +36,7 @@ class MeetingOutcome < ApplicationRecord
     information: 0,
     decision: 1,
     work_package: 2
-  }.freeze, suffix: true, default: "information"
+  }.freeze, suffix: true, default: "information", validate: true
 
   validates :meeting_agenda_item, presence: true
   validates :notes, presence: { if: -> { information_kind? } }

modules/meeting/config/locales/en.yml

@@ -62,6 +62,8 @@ en:
         position: "Position"
         presenter: "Presenter"
         title: "Title"
+      meeting_outcome:
+        kind: "Kind"
       meeting_participant:
         attended: "Attended"
         invited: "Invited"

modules/meeting/spec/requests/api/v3/meeting_outcomes/outcomes_by_agenda_item_resource_spec.rb

@@ -159,6 +159,29 @@
       end
     end
 
+    context "with an invalid kind value" do
+      let(:body) do
+        {
+          kind: "not_a_real_kind",
+          notes: { raw: "Outcome with invalid kind" },
+          _links: {
+            agendaItem: {
+              href: api_v3_paths.meeting_agenda_item(agenda_item.id)
+            }
+          }
+        }.to_json
+      end
+
+      it "returns 422 rather than raising" do
+        expect { response }.not_to raise_error
+        expect(response).to have_http_status(:unprocessable_entity)
+      end
+
+      it "does not create the outcome" do
+        expect { response }.not_to change(MeetingOutcome, :count)
+      end
+    end
+
     context "when creating a work package outcome" do
       let(:permissions) { %i[view_meetings manage_outcomes view_work_packages] }
       let(:work_package) { create(:work_package, project:) }