[#71059] Limit sprint goal text length

Keep sprint goals short enough for dialog entry and header display while
leaving the column type unchanged.

https://community.openproject.org/wp/71059

Author: myabc

modules/backlogs/app/forms/backlogs/sprints/owned_goal_form.rb

@@ -39,7 +39,8 @@ class OwnedGoalForm < ApplicationForm
         f.text_field(
           name: :text,
           label: Sprint.human_attribute_name(:goal),
-          disabled:
+          disabled:,
+          maxlength: SprintGoal::TEXT_MAX_LENGTH
         )
       end
     end

modules/backlogs/app/forms/backlogs/sprints/shared_goal_form.rb

@@ -40,7 +40,8 @@ class SharedGoalForm < ApplicationForm
           name: :text,
           label: goal_label,
           caption: I18n.t("backlogs.sprint_form.goal_caption"),
-          disabled:
+          disabled:,
+          maxlength: SprintGoal::TEXT_MAX_LENGTH
         )
       end
 

modules/backlogs/app/models/sprint_goal.rb

@@ -29,12 +29,14 @@
 #++
 
 class SprintGoal < ApplicationRecord
+  TEXT_MAX_LENGTH = 500
+
   belongs_to :sprint, inverse_of: :goals
   belongs_to :project
 
   normalizes :text, with: ->(text) { text.strip.presence }
 
-  validates :text, presence: true
+  validates :text, presence: true, length: { maximum: TEXT_MAX_LENGTH }
 
   validates :project_id,
             uniqueness: { scope: :sprint_id, message: :project_already_has_goal }

modules/backlogs/spec/forms/backlogs/sprints/owned_goal_form_spec.rb

@@ -67,6 +67,12 @@ def render_form
     expect(rendered_form).to have_field("sprint[goal][text]")
   end
 
+  it "limits the goal text field length" do
+    expect(rendered_form).to have_css(
+      "input[name='sprint[goal][text]'][maxlength='#{SprintGoal::TEXT_MAX_LENGTH}']"
+    )
+  end
+
   it "does not render the shared sprint caption" do
     expect(rendered_form).to have_no_text(I18n.t("backlogs.sprint_form.goal_caption"))
   end

modules/backlogs/spec/forms/backlogs/sprints/shared_goal_form_spec.rb

@@ -70,6 +70,12 @@ def render_form
     expect(rendered_form).to have_field("sprint[goal][text]")
   end
 
+  it "limits the goal text field length" do
+    expect(rendered_form).to have_css(
+      "input[name='sprint[goal][text]'][maxlength='#{SprintGoal::TEXT_MAX_LENGTH}']"
+    )
+  end
+
   it "renders the shared sprint caption" do
     expect(rendered_form).to have_text(I18n.t("backlogs.sprint_form.goal_caption"))
   end

modules/backlogs/spec/models/sprint_goal_spec.rb

@@ -59,6 +59,13 @@
       expect(sprint_goal).not_to be_valid
     end
 
+    it "limits text to 500 characters" do
+      sprint_goal.text = "a" * 501
+
+      expect(sprint_goal).not_to be_valid
+      expect(sprint_goal.errors).to be_added(:text, :too_long, count: 500)
+    end
+
     it "validates uniqueness of project_id scoped to sprint_id" do
       sprint_goal.save!
       expect(sprint_goal).to validate_uniqueness_of(:project_id)