Allow to define whether wikis are enabled by default

Since enablement of wikis is not handled through a module anymore,
we have to treat them explicitly.

Author: NobodysNightmare

app/forms/settings/new_project_settings_form.rb

@@ -35,6 +35,10 @@ class NewProjectSettingsForm < ApplicationForm
         name: :default_projects_public
       )
 
+      f.check_box(
+        name: :default_projects_wiki
+      )
+
       f.check_box_group(
         name: :default_projects_modules,
         label: I18n.t(:setting_default_projects_modules)

app/services/projects/set_attributes_service.rb

@@ -60,6 +60,7 @@ def set_default_attributes(attributes)
       attribute_keys = attributes.keys.map(&:to_s)
 
       set_default_public(attribute_keys.include?("public"))
+      set_default_wiki
       set_default_module_names(attribute_keys.include?("enabled_module_names"))
       set_default_types(attribute_keys.intersect?(%w[types type_ids project_types]))
       set_default_active_work_package_custom_fields(attribute_keys.include?("work_package_custom_fields"))
@@ -70,6 +71,10 @@ def set_default_public(provided)
       model.public = Setting.default_projects_public? unless provided
     end
 
+    def set_default_wiki
+      model.build_wiki(start_page: "Wiki", enabled: Setting.default_projects_wiki?) if model.wiki.nil?
+    end
+
     def set_default_module_names(provided)
       model.enabled_module_names = Setting.default_projects_modules if !provided && model.enabled_module_names.empty?
     end

config/constants/settings/definition.rb

@@ -372,7 +372,7 @@ class Definition
       },
       default_projects_modules: {
         default: -> {
-          base_modules = %w[calendar board_view work_package_tracking gantt news costs wiki]
+          base_modules = %w[calendar board_view work_package_tracking gantt news costs]
           if Setting.real_time_text_collaboration_enabled?
             base_modules + %w[documents]
           else
@@ -384,6 +384,9 @@ class Definition
       default_projects_public: {
         default: false
       },
+      default_projects_wiki: {
+        default: true
+      },
       demo_projects_available: {
         default: false
       },

config/locales/en.yml

@@ -5422,6 +5422,7 @@ en:
   setting_default_language: "Default language"
   setting_default_projects_modules: "Default enabled modules for new projects"
   setting_default_projects_public: "New projects are public by default"
+  setting_default_projects_wiki: "Enables wiki functionality for new projects by default"
   setting_diff_max_lines_displayed: "Max number of diff lines displayed"
   setting_disable_password_login: "Disable password authentication"
   setting_display_subprojects_work_packages: "Display subprojects work packages on main projects by default"

docs/installation-and-operations/configuration/environment/README.md

@@ -197,8 +197,9 @@ OPENPROJECT_DAYS__PER__MONTH (default=20) This will define what is considered a
 OPENPROJECT_DEFAULT__AUTO__HIDE__POPUPS (default=true) Whether to automatically hide success notifications by default
 OPENPROJECT_DEFAULT__COMMENT__SORT__ORDER (default="asc") Default sort order for activities
 OPENPROJECT_DEFAULT__LANGUAGE (default="en") Default language
-OPENPROJECT_DEFAULT__PROJECTS__MODULES (default=["calendar", "board_view", "work_package_tracking", "gantt", "news", "costs", "wiki"]) Default enabled modules for new projects
+OPENPROJECT_DEFAULT__PROJECTS__MODULES (default=["calendar", "board_view", "work_package_tracking", "gantt", "news", "costs"]) Default enabled modules for new projects
 OPENPROJECT_DEFAULT__PROJECTS__PUBLIC (default=false) New projects are public by default
+OPENPROJECT_DEFAULT__PROJECTS__WIKI (default=true) Enables wiki functionality for new projects by default
 OPENPROJECT_DEMO__PROJECTS__AVAILABLE (default=false)
 OPENPROJECT_DEMO__VIEW__OF__TYPE__GANTT__SEEDED (default=false)
 OPENPROJECT_DEMO__VIEW__OF__TYPE__TEAM__PLANNER__SEEDED (default=false)

spec/models/setting_spec.rb

@@ -564,7 +564,7 @@
   describe "default_projects_modules conditional default" do
     shared_examples "base modules unchanged" do
       it "includes the base modules" do
-        base_modules = %w[calendar board_view work_package_tracking gantt news costs wiki]
+        base_modules = %w[calendar board_view work_package_tracking gantt news costs]
         expect(Settings::Definition[:default_projects_modules].default).to include(*base_modules)
       end
     end

spec/requests/api/v3/projects/copy/copy_resource_spec.rb

@@ -159,7 +159,7 @@
         expect(project).to be_present
 
         expect(source_project.wiki.pages.count).to eq 1
-        expect(project.wiki).to be_nil
+        expect(project.wiki.pages.count).to eq 0
 
         expect(source_project.work_packages.count).to eq 1
         expect(project.work_packages.count).to eq 1

spec/services/projects/copy_service_integration_spec.rb

@@ -1306,7 +1306,9 @@ def copy_of(original_work_package)
         expect(project_copy.work_packages.count).to eq 0
         expect(project_copy.forums.count).to eq 0
         # Default wiki page
-        expect(project_copy.wiki).to be_nil
+        expect(project_copy.wiki).to be_present
+        expect(project_copy.wiki.enabled?).to eq(source.wiki.enabled?)
+        expect(project_copy.wiki.pages.count).to eq 0
         expect(project_copy.queries.count).to eq 0
         expect(project_copy.versions.count).to eq 0
         expect(project_copy.phases.count).to eq 0

spec/services/projects/set_attributes_service_spec.rb

@@ -159,6 +159,40 @@
         end
       end
 
+      describe "wiki default value" do
+        context "when enabling wikis by default", with_settings: { default_projects_wiki: true } do
+          it "enables the wiki" do
+            expect(subject.result.wiki).to be_enabled
+          end
+
+          context "and when the project already has a disabled wiki" do
+            before do
+              project.build_wiki(enabled: false)
+            end
+
+            it "keeps the wiki disabled" do
+              expect(subject.result.wiki).not_to be_enabled
+            end
+          end
+        end
+
+        context "when disabling wikis by default", with_settings: { default_projects_wiki: false } do
+          it "creates the wiki, but disabled" do
+            expect(subject.result.wiki).not_to be_enabled
+          end
+
+          context "and when the project already has an enabled wiki" do
+            before do
+              project.build_wiki(enabled: true)
+            end
+
+            it "keeps the wiki enabled" do
+              expect(subject.result.wiki).to be_enabled
+            end
+          end
+        end
+      end
+
       describe "enabled_module_names default value", with_settings: { default_projects_modules: ["lorem", "ipsum"] } do
         context "with a value for enabled_module_names provided" do
           let(:call_attributes) do