[COMMS-843] Make Target Versions the default for new installations (#24690)

* [COMMS-843] Remove the work_package_multiple_versions feature flag

* [COMMS-843] Enable multiple target versions per WP by default

* [COMMS-843] Pin specs that relied on multiple versions being off

With the setting now defaulting to on, specs describing the legacy
single-version behaviour no longer get it implicitly. State the
assumption where it is load-bearing: contexts named "inactive"/"off"/
"disabled", the single-value validation rule, and the surfaces that
expose the deprecated version column (query columns, query form API,
PDF export, grouping and sorting by version).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* iron out the test coverage a bit

* appease rubocop

* [COMMS-843] Read the target version links via parse_json

`response.parsed_body` is not available here: these are rack-test
requests, so `response` is a Rack::MockResponse. Use json_spec's
`parse_json`, which reads the body without tripping
Rails/ResponseParsedBody.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* [COMMS-843] Pin the feature specs covering the single version field

Same reason as the unit specs: with the setting on by default, the work
package form, table columns, sort options and form configuration expose
target versions instead of the deprecated version, so the specs
describing the single-version UI have to say so.

Whole spec pinned where the version attribute runs through all of it
(baseline rendering, form configuration, assign_versions permission),
single example or context where it does not.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* [COMMS-843] Exercise the target versions field on the new default

Two of the pinned specs already drove the targetVersions field; they only
needed the version to exist before the page loads, since the multi-value
field resolves its options then, unlike the single-value one. Create it
eagerly and drop the pins, so both cover the default again.

Also cover the form configuration with the feature on, which had no
feature-level coverage left: target versions is offered in place of the
deprecated version and can be dragged out of the group.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* [COMMS-843] Restore the pins on the work package form specs

Creating the version before the page loads was not the reason these
specs failed: the target versions autocompleter in the work package
full view offers no options at all while multiple versions is enabled,
so nothing can be picked by name. Pin them back to the single version
field, which is what they describe, and leave the empty autocompleter
to be looked at on its own.

The form configuration coverage added alongside stays - it passes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* remove some old flag references

* pin some more tests after merge from dev

* pin last test

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Author: thykel

config/constants/settings/definition.rb

@@ -1362,7 +1362,7 @@ class Definition
       work_package_multiple_versions: {
         description: "Enable multiple version assignments on work packages.",
         format: :boolean,
-        default: false
+        default: true
       },
       work_packages_activities_tab_polling_interval_in_ms: {
         description: "Interval in milliseconds at which the work package activities tab polls for updates.",

modules/boards/spec/features/action_boards/version_board_spec.rb

@@ -99,7 +99,7 @@ def create_new_version_board
       login_as(user)
     end
 
-    it "allows management of boards" do
+    it "allows management of boards", with_settings: { work_package_multiple_versions: false } do
       board_page = create_new_version_board
 
       board_page.expect_card "Open version", work_package.subject, present: true

modules/reporting/spec/models/cost_query/filter_spec.rb

@@ -291,14 +291,14 @@ def create_matching_object_with_time_entries(factory, work_package_field, entry_
         expect(query.result.count).to eq(3)
       end
 
-      it "labels the filter 'Version' while multiple versions is off" do
+      it "labels the filter 'Version' while multiple versions is off", with_settings: { work_package_multiple_versions: false } do
         expect(CostQuery::Filter::VersionId.label).to eq("Version")
       end
 
       # While the feature is off a work package is single-version, so the filter
       # only sees its primary target version (the lowest version id, i.e. what
       # target_versions.first returns).
-      it "matches a work package through its primary target version" do
+      it "matches a work package through its primary target version", with_settings: { work_package_multiple_versions: false } do
         primary_version = create(:version, project:)
         secondary_version = create(:version, project:)
         work_package = create_work_package_with_time_entry(version: primary_version)
@@ -308,7 +308,8 @@ def create_matching_object_with_time_entries(factory, work_package_field, entry_
         expect(query.result.count).to eq(1)
       end
 
-      it "ignores a non-primary target version while multiple versions is off" do
+      it "ignores a non-primary target version while multiple versions is off",
+         with_settings: { work_package_multiple_versions: false } do
         primary_version = create(:version, project:)
         secondary_version = create(:version, project:)
         work_package = create_work_package_with_time_entry(version: primary_version)
@@ -321,7 +322,8 @@ def create_matching_object_with_time_entries(factory, work_package_field, entry_
       # Off-mode negation runs on the primary-only (one-to-one) join, so the
       # default "is not" operator is already correct without the multi-version
       # NOT EXISTS override.
-      it "negates on the primary target version while multiple versions is off" do
+      it "negates on the primary target version while multiple versions is off",
+         with_settings: { work_package_multiple_versions: false } do
         primary_version = create(:version, project:)
         secondary_version = create(:version, project:)
         work_package = create_work_package_with_time_entry(version: primary_version)
@@ -332,7 +334,8 @@ def create_matching_object_with_time_entries(factory, work_package_field, entry_
         expect(query.result.count).to eq(0)
       end
 
-      it "keeps a work package when negating a non-primary target version while off" do
+      it "keeps a work package when negating a non-primary target version while off",
+         with_settings: { work_package_multiple_versions: false } do
         primary_version = create(:version, project:)
         secondary_version = create(:version, project:)
         work_package = create_work_package_with_time_entry(version: primary_version)

modules/reporting/spec/models/cost_query/group_by_spec.rb

@@ -97,15 +97,16 @@
       expect(query.result.size).to eq(2)
     end
 
-    it "labels the group 'Version' while multiple versions is off" do
+    it "labels the group 'Version' while multiple versions is off", with_settings: { work_package_multiple_versions: false } do
       expect(CostQuery::GroupBy::VersionId.label).to eq("Version")
     end
 
     # While the feature is off a work package is single-version, so it is grouped
     # under its primary target version only (the lowest version id, i.e. what
     # target_versions.first returns) and the grouped total matches the ungrouped
     # entry count.
-    it "computes group_by Version, listing a work package under its primary target version" do
+    it "computes group_by Version, listing a work package under its primary target version",
+       with_settings: { work_package_multiple_versions: false } do
       version1 = create(:version, project: project1)
       version2 = create(:version, project: project1)
       work_package = create(:work_package, project: project1, type:, version: version1)

spec/contracts/work_package_types/update_form_configuration_contract_spec.rb

@@ -237,7 +237,8 @@ module WorkPackageTypes
           end
         end
 
-        context "when the multiple versions feature is inactive" do
+        context "when the multiple versions feature is inactive",
+                with_settings: { work_package_multiple_versions: false } do
           it "accepts the deprecated version" do
             model.attribute_groups = [["foo", ["version"]]]
 

spec/contracts/work_packages/base_contract_spec.rb

@@ -1326,7 +1326,8 @@
         work_package.target_version_ids_replacements = [assignable_version.id, other_assignable_version.id]
       end
 
-      context "when the multiple-versions feature is disabled" do
+      context "when the multiple-versions feature is disabled",
+              with_settings: { work_package_multiple_versions: false } do
         before { contract.validate }
 
         it "rejects more than one target version" do

spec/controllers/work_package_types/form_configuration_tab_controller_rows_spec.rb

@@ -36,7 +36,7 @@
 
   before do
     allow(User).to receive(:current).and_return(user)
-    type.update_column(:attribute_groups, [[:details, %w[priority version]]])
+    type.update_column(:attribute_groups, [[:details, %w[priority category]]])
   end
 
   describe "PUT #drop", with_ee: %i[edit_attribute_groups] do
@@ -52,7 +52,7 @@
     it "moves the row into another active section at the requested position" do
       type.update_column(:attribute_groups, [
                            [:details, %w[priority]],
-                           ["Custom group", %w[version]]
+                           ["Custom group", %w[category]]
                          ])
 
       put :drop,
@@ -62,7 +62,7 @@
       expect(response).to have_http_status(:ok)
 
       target_group = type.reload.attribute_groups.find { |group| group.key == "Custom group" }
-      expect(target_group.members).to eq(%w[priority version])
+      expect(target_group.members).to eq(%w[priority category])
     end
   end
 end

spec/features/types/form_configuration_spec.rb

@@ -30,7 +30,8 @@
 
 require "spec_helper"
 
-RSpec.describe "form configuration", :js, :selenium do
+RSpec.describe "form configuration", :js, :selenium,
+               with_settings: { work_package_multiple_versions: false } do
   shared_let(:admin) { create(:admin) }
   let(:type) { create(:type) }
 
@@ -250,6 +251,25 @@ def persisted_attribute_order(type, group_key)
         loading_indicator_saveguard
       end
 
+      context "with multiple versions enabled",
+              with_settings: { work_package_multiple_versions: true } do
+        it "offers target versions in place of the deprecated version" do
+          form.expect_group "details",
+                            "Details",
+                            { key: :category, translation: "Category" },
+                            { key: :date, translation: "Date" },
+                            { key: :priority, translation: "Priority" },
+                            { key: :target_versions, translation: "Target versions" }
+
+          form.drag_and_drop(form.find_attribute_handle(:target_versions), form.inactive_group)
+          form.expect_inactive(:target_versions)
+
+          form.save_changes
+
+          expect(persisted_attribute_order(type, :details)).not_to include("target_versions")
+        end
+      end
+
       context "with field format labels" do
         let!(:custom_field) { create(:issue_custom_field, :integer, name: "MyNumber") }
 

spec/features/work_packages/details/inplace_editor/version_editor_spec.rb

@@ -57,7 +57,7 @@
       login_as(user)
     end
 
-    it "renders hierarchical versions" do
+    it "renders hierarchical versions", with_settings: { work_package_multiple_versions: false } do
       work_package_page.visit!
       work_package_page.ensure_page_loaded
 

spec/features/work_packages/edit_on_assign_version_permission_spec.rb

@@ -3,7 +3,7 @@
 require "spec_helper"
 require "features/page_objects/notification"
 
-RSpec.describe "edit work package", :js do
+RSpec.describe "edit work package", :js, with_settings: { work_package_multiple_versions: false } do
   let(:current_user) do
     create(:user,
            firstname: "Dev",