[#71059] Merge sprint goal forms

Use one configurable form for owned and shared sprint goal fields.

Author: myabc

modules/backlogs/app/components/backlogs/sprint_form_component.html.erb

@@ -62,7 +62,12 @@ See COPYRIGHT and LICENSE files for more details.
         end
         flex.with_row do
           f.fields_for(:goal, goal) do |goal_fields|
-            render goal_form_class.new(goal_fields, disabled: !can_edit_goal?)
+            render Backlogs::Sprints::GoalForm.new(
+              goal_fields,
+              label: goal_label,
+              caption: goal_caption,
+              disabled: !can_edit_goal?
+            )
           end
         end
       end

modules/backlogs/app/components/backlogs/sprint_form_component.rb

@@ -80,14 +80,18 @@ def goal
       sprint.goals.find_or_initialize_by(project:)
     end
 
-    def goal_form_class
+    def goal_label
       if shared_sprint?
-        Backlogs::Sprints::SharedGoalForm
+        I18n.t("backlogs.sprint_form.goal_for_this_project_label", attribute: Sprint.human_attribute_name(:goal))
       else
-        Backlogs::Sprints::OwnedGoalForm
+        Sprint.human_attribute_name(:goal)
       end
     end
 
+    def goal_caption
+      I18n.t("backlogs.sprint_form.goal_caption") if shared_sprint?
+    end
+
     private
 
     def http_verb

…orms/backlogs/sprints/owned_goal_form.rb …/app/forms/backlogs/sprints/goal_form.rbmodules/backlogs/app/forms/backlogs/sprints/owned_goal_form.rb renamed to modules/backlogs/app/forms/backlogs/sprints/goal_form.rb modules/backlogs/app/forms/backlogs/sprints/owned_goal_form.rb renamed to modules/backlogs/app/forms/backlogs/sprints/goal_form.rb

@@ -30,15 +30,18 @@
 
 module Backlogs
   module Sprints
-    class OwnedGoalForm < ApplicationForm
+    class GoalForm < ApplicationForm
       extend Dry::Initializer
 
+      option :label
+      option :caption, optional: true
       option :disabled, default: -> { false }
 
       form do |f|
         f.text_field(
           name: :text,
-          label: Sprint.human_attribute_name(:goal),
+          label:,
+          caption:,
           disabled:,
           maxlength: SprintGoal::TEXT_MAX_LENGTH
         )

modules/backlogs/app/forms/backlogs/sprints/shared_goal_form.rb

@@ -30,25 +30,29 @@
 
 require "rails_helper"
 
-RSpec.describe Backlogs::Sprints::OwnedGoalForm, type: :forms do
+RSpec.describe Backlogs::Sprints::GoalForm, type: :forms do
   include ViewComponent::TestHelpers
 
   let(:project) { create(:project) }
   let(:sprint) { create(:sprint, project:) }
-  let(:disabled) { false }
   let(:goal) { sprint.goals.find_or_initialize_by(project:) }
+  let(:label) { Sprint.human_attribute_name(:goal) }
+  let(:caption) { nil }
+  let(:disabled) { false }
   let(:form_arguments) { { url: "/foo", model: sprint, scope: :sprint } }
 
   def render_form
     render_in_view_context(
       described_class,
       form_arguments,
       goal,
+      label,
+      caption,
       disabled
-    ) do |described_class, form_arguments, goal, disabled|
+    ) do |described_class, form_arguments, goal, label, caption, disabled|
       primer_form_with(**form_arguments) do |f|
         f.fields_for(:goal, goal) do |goal_fields|
-          render(described_class.new(goal_fields, disabled:))
+          render(described_class.new(goal_fields, label:, caption:, disabled:))
         end
       end
     end
@@ -59,8 +63,8 @@ def render_form
     page
   end
 
-  it "renders the goal field" do
-    expect(rendered_form).to have_field(Sprint.human_attribute_name(:goal), disabled: false)
+  it "renders the goal field with the provided label" do
+    expect(rendered_form).to have_field(label, disabled: false)
   end
 
   it "renders the goal text field under the goal command param" do
@@ -73,23 +77,35 @@ def render_form
     )
   end
 
-  it "does not render the shared sprint caption" do
+  it "does not render a blank caption" do
     expect(rendered_form).to have_no_text(I18n.t("backlogs.sprint_form.goal_caption"))
   end
 
+  context "with a caption" do
+    let(:label) do
+      I18n.t("backlogs.sprint_form.goal_for_this_project_label", attribute: Sprint.human_attribute_name(:goal))
+    end
+    let(:caption) { I18n.t("backlogs.sprint_form.goal_caption") }
+
+    it "renders the project-specific label and caption" do
+      expect(rendered_form).to have_field(label, disabled: false)
+      expect(rendered_form).to have_text(caption)
+    end
+  end
+
   context "when a goal exists for the project" do
     let!(:goal) { create(:sprint_goal, sprint:, project:, text: "Ship dashboard") }
 
     it "renders the goal value" do
-      expect(rendered_form).to have_field(Sprint.human_attribute_name(:goal), with: "Ship dashboard")
+      expect(rendered_form).to have_field(label, with: "Ship dashboard")
     end
   end
 
   context "when disabled" do
     let(:disabled) { true }
 
     it "renders the goal field as disabled" do
-      expect(rendered_form).to have_field(Sprint.human_attribute_name(:goal), disabled: true)
+      expect(rendered_form).to have_field(label, disabled: true)
     end
   end
 end