Skip to content

Commit bb7d6ac

Browse files
committed
Remove default which are now correctly kept in the component
1 parent 8e86f66 commit bb7d6ac

3 files changed

Lines changed: 1 addition & 20 deletions

File tree

app/components/header/projects/filterable_tree_view_component.html.erb

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,7 @@ See COPYRIGHT and LICENSE files for more details.
3333
src: tree_src,
3434
include_sub_items_check_box_arguments: { hidden: true },
3535
filter_mode_control_arguments: logged? ? {} : { hidden: true },
36-
filter_input_arguments: { name: "filter",
37-
label: t(:label_filter),
38-
visually_hide_label: true,
39-
autofocus: true,
36+
filter_input_arguments: { autofocus: true,
4037
data: { test_selector: "op-header-project-select--search" } },
4138
no_results_node_arguments: { data: { test_selector: "op-header-project-select--no-results" },
4239
label: I18n.t("filterable_tree_view.no_results_text") }

modules/wikis/app/forms/wikis/create_new_wiki_page_form.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,6 @@ class CreateNewWikiPageForm < ApplicationForm
5252
filter_mode_control_arguments: { hidden: true },
5353
filter_input_arguments: {
5454
placeholder: I18n.t("wikis.link_existing_wiki_page_form.placeholder"),
55-
# every other property is just refilling the default values,
56-
# as those are not merged into custom arguments
57-
name: :filter,
58-
label: I18n.t(:button_filter),
59-
type: :search,
60-
leading_visual: { icon: :search },
61-
visually_hide_label: true,
62-
show_clear_button: true
6355
},
6456
include_sub_items_check_box_arguments: { hidden: true },
6557
no_results_node_arguments: { label: I18n.t("wikis.link_existing_wiki_page_form.no_results") }

modules/wikis/app/forms/wikis/link_existing_wiki_page_form.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,6 @@ class LinkExistingWikiPageForm < ApplicationForm
4242
filter_mode_control_arguments: { hidden: true },
4343
filter_input_arguments: {
4444
placeholder: I18n.t("wikis.link_existing_wiki_page_form.placeholder"),
45-
# every other property is just refilling the default values,
46-
# as those are not merged into custom arguments
47-
name: :filter,
48-
label: I18n.t(:button_filter),
49-
type: :search,
50-
leading_visual: { icon: :search },
51-
visually_hide_label: true,
52-
show_clear_button: true
5345
},
5446
include_sub_items_check_box_arguments: { hidden: true },
5547
no_results_node_arguments: { label: I18n.t("wikis.link_existing_wiki_page_form.no_results") }

0 commit comments

Comments
 (0)