[OP-9533] Translation error in "add work package" macro in WYSWIG (#24750)

* Use + type instead of a translation key

* Update specs

Author: bsatarnejad

config/locales/en.yml

@@ -3941,7 +3941,6 @@ en:
         invalid_type: "No type found with name '%{type}' in project '%{project}'."
         no_project_context: "Calling create_work_package_link macro from outside project context."
       link_name: "New work package"
-      link_name_type: "New %{type_name}"
     errors:
       missing_or_invalid_parameter: "Missing or invalid macro parameter."
     include_wiki_page:

lib/open_project/text_formatting/filters/macros/create_work_package_link.rb

@@ -64,7 +64,7 @@ def work_package_link(macro, context) # rubocop:disable Metrics/AbcSize
         end
 
         ApplicationController.helpers.link_to(
-          I18n.t("macros.create_work_package_link.link_name_type", type_name:),
+          "+ #{type_name}",
           new_project_work_packages_path(project_id: project.identifier, type: type.id),
           class: class_name
         )

spec/lib/open_project/text_formatting/markdown/work_package_buttons_macro_spec.rb

@@ -108,7 +108,7 @@ def error_html(exception_msg)
       let(:expected) do
         <<~EXPECTED
           <p class="op-uc-p">
-            <a class="op-uc-link" target="_top" href="/projects/my-project/work_packages/new?type=#{type.id}">New MyTaskName</a>
+            <a class="op-uc-link" target="_top" href="/projects/my-project/work_packages/new?type=#{type.id}">+ MyTaskName</a>
           </p>
         EXPECTED
       end
@@ -125,7 +125,7 @@ def error_html(exception_msg)
         let(:expected) do
           <<~EXPECTED
             <p class="op-uc-p">
-              <a class="button op-uc-link" target="_top" href="/projects/my-project/work_packages/new?type=#{type.id}">New MyTaskName</a>
+              <a class="button op-uc-link" target="_top" href="/projects/my-project/work_packages/new?type=#{type.id}">+ MyTaskName</a>
             </p>
           EXPECTED
         end