Skip to content

Commit e8d2883

Browse files
committed
[DREAM-802] Show blankslate on empty filter
Filtering the phase definitions to no matches left a bare header box with a detached plain-text notice below it. The list's own empty state now appears inside the box through the dynamic lifecycle. https://community.openproject.org/wp/DREAM-802
1 parent 6fc06a4 commit e8d2883

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

app/components/settings/project_phase_definitions/index_component.html.erb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ See COPYRIGHT and LICENSE files for more details.
7777
container: "project-phase-definitions",
7878
position: :relative,
7979
mb: 3,
80+
empty_state_behavior: :dynamic,
8081
data: drop_target_config
8182
)
8283
) do |list|
@@ -103,11 +104,6 @@ See COPYRIGHT and LICENSE files for more details.
103104
list.with_empty_state(title: t("settings.project_phase_definitions.non_defined"))
104105
end
105106
end
106-
flex.with_row(display: :none, data: { "projects--settings--border-box-filter-target": "noResultsText" }) do
107-
render Primer::Beta::Text.new do
108-
I18n.t("js.autocompleter.notFoundText")
109-
end
110-
end
111107
end
112108
end
113109
%>

0 commit comments

Comments
 (0)