Skip to content

Commit 081fbd7

Browse files
authored
Merge pull request #374 from opf/bump/primer-upstream
Bump/primer upstream 0.46.0
2 parents 71ba4de + 10a254c commit 081fbd7

33 files changed

Lines changed: 174 additions & 110 deletions

.changeset/cyan-readers-prove.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@openproject/primer-view-components': minor
3+
---
4+
5+
Enable use_experimental_non_local_form for all SelectPanels

.changeset/fruity-rooms-travel.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@openproject/primer-view-components': patch
3+
---
4+
5+
Updates SelectPanel anchor to allow IconButtons

.changeset/tiny-frogs-pretend.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@openproject/primer-view-components": patch
3+
---
4+
5+
Remove left/right bg color borders from Avatar Stack

.github/workflows/test.yml

Lines changed: 25 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ env:
2525
jobs:
2626
accessibility:
2727
name: Accessibility
28+
timeout-minutes: 10
2829
runs-on:
2930
labels:
3031
- runs-on
@@ -34,12 +35,12 @@ jobs:
3435
- uses: actions/checkout@v5
3536
- uses: ruby/setup-ruby@v1
3637
with:
37-
ruby-version: '3.4'
38+
ruby-version: "3.4"
3839
bundler-cache: true
3940
- uses: actions/setup-node@v5
4041
with:
4142
node-version: 20
42-
cache: 'npm'
43+
cache: "npm"
4344
cache-dependency-path: |
4445
package-lock.json
4546
demo/package-lock.json
@@ -50,24 +51,12 @@ jobs:
5051
- name: Test
5152
run: bundle exec rake test:accessibility
5253
components:
53-
name: Components
54-
runs-on:
55-
labels:
56-
- runs-on
57-
- runner=16cpu-linux-x64
58-
- run-id=${{ github.run_id }}
54+
name: Components (${{ matrix.label }})
55+
runs-on: ubuntu-latest
5956
strategy:
6057
fail-fast: false
6158
matrix:
62-
include:
63-
- rails_version: '7.2.2.1'
64-
ruby_version: '3.2'
65-
- rails_version: '7.2.2.1'
66-
ruby_version: '3.3'
67-
- rails_version: 'main'
68-
ruby_version: '3.3'
69-
- rails_version: 'main'
70-
ruby_version: '3.4'
59+
include: ${{ fromJson(vars.TEST_MATRIX) }}
7160
steps:
7261
- uses: actions/checkout@v5
7362
- uses: ruby/setup-ruby@v1
@@ -78,7 +67,7 @@ jobs:
7867
- uses: actions/setup-node@v5
7968
with:
8069
node-version: 20
81-
cache: 'npm'
70+
cache: "npm"
8271
- name: Build
8372
run: |
8473
npm ci
@@ -96,24 +85,12 @@ jobs:
9685
RUBY_VERSION: ${{ matrix.ruby_version }}
9786
RAILS_VERSION: ${{ matrix.rails_version }}
9887
lib:
99-
name: Lib
100-
runs-on:
101-
labels:
102-
- runs-on
103-
- runner=16cpu-linux-x64
104-
- run-id=${{ github.run_id }}
88+
name: Lib (${{ matrix.label }})
89+
runs-on: ubuntu-latest
10590
strategy:
10691
fail-fast: false
10792
matrix:
108-
include:
109-
- rails_version: '7.2.2.1'
110-
ruby_version: '3.2'
111-
- rails_version: '7.2.2.1'
112-
ruby_version: '3.3'
113-
- rails_version: 'main'
114-
ruby_version: '3.3'
115-
- rails_version: 'main'
116-
ruby_version: '3.4'
93+
include: ${{ fromJson(vars.TEST_MATRIX) }}
11794
steps:
11895
- uses: actions/checkout@v5
11996
- uses: ruby/setup-ruby@v1
@@ -124,7 +101,7 @@ jobs:
124101
- uses: actions/setup-node@v5
125102
with:
126103
node-version: 20
127-
cache: 'npm'
104+
cache: "npm"
128105
- name: Build
129106
run: |
130107
npm ci
@@ -142,20 +119,12 @@ jobs:
142119
RUBY_VERSION: ${{ matrix.ruby_version }}
143120
RAILS_VERSION: ${{ matrix.rails_version }}
144121
performance:
145-
name: Performance
122+
name: Performance (${{ matrix.label }})
146123
runs-on: ubuntu-latest
147124
strategy:
148125
fail-fast: false
149126
matrix:
150-
include:
151-
- rails_version: '7.2.2.1'
152-
ruby_version: '3.2'
153-
- rails_version: '7.2.2.1'
154-
ruby_version: '3.3'
155-
- rails_version: 'main'
156-
ruby_version: '3.3'
157-
- rails_version: 'main'
158-
ruby_version: '3.4'
127+
include: ${{ fromJson(vars.TEST_MATRIX) }}
159128
steps:
160129
- uses: actions/checkout@v5
161130
- uses: ruby/setup-ruby@v1
@@ -183,12 +152,12 @@ jobs:
183152
- uses: actions/checkout@v5
184153
- uses: ruby/setup-ruby@v1
185154
with:
186-
ruby-version: '3.2'
155+
ruby-version: "3.2"
187156
bundler-cache: true
188157
- uses: actions/setup-node@v5
189158
with:
190159
node-version: 20
191-
cache: 'npm'
160+
cache: "npm"
192161
cache-dependency-path: |
193162
package-lock.json
194163
demo/package-lock.json
@@ -206,12 +175,12 @@ jobs:
206175
- uses: actions/checkout@v5
207176
- uses: ruby/setup-ruby@v1
208177
with:
209-
ruby-version: '3.2'
178+
ruby-version: "3.2"
210179
bundler-cache: true
211180
- uses: actions/setup-node@v5
212181
with:
213182
node-version: 20
214-
cache: 'npm'
183+
cache: "npm"
215184
cache-dependency-path: |
216185
package-lock.json
217186
demo/package-lock.json
@@ -235,12 +204,12 @@ jobs:
235204
fetch-depth: 0
236205
- uses: ruby/setup-ruby@v1
237206
with:
238-
ruby-version: '3.2'
207+
ruby-version: "3.2"
239208
bundler-cache: true
240209
- uses: actions/setup-node@v5
241210
with:
242211
node-version: 20
243-
cache: 'npm'
212+
cache: "npm"
244213
cache-dependency-path: |
245214
package-lock.json
246215
demo/package-lock.json
@@ -281,7 +250,7 @@ jobs:
281250
commit_message: Generating component snapshots
282251
file_pattern: .playwright/screenshots/**/*.png .playwright/screenshots/**/*.yml
283252
push_options: --force-with-lease
284-
- name: 'Changes detected'
253+
- name: "Changes detected"
285254
if: steps.auto-commit.outputs.changes_detected == 'true'
286255
uses: phulsechinmay/rewritable-pr-comment@v0.3.0
287256
with:
@@ -292,7 +261,7 @@ jobs:
292261
293262
[Review differences](https://github.com/opf/primer_view_components/pull/${{ github.event.number }}/files?file-filters%5B%5D=.png&file-filters%5B%5D=.yml&show-viewed-files=false)
294263
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
295-
COMMENT_IDENTIFIER: 'visual-comparison-diff'
264+
COMMENT_IDENTIFIER: "visual-comparison-diff"
296265
- uses: actions/upload-artifact@v4
297266
with:
298267
name: playwright-report
@@ -303,28 +272,24 @@ jobs:
303272
run: exit 1
304273
selectors:
305274
name: CSS coverage
306-
runs-on:
307-
labels:
308-
- runs-on
309-
- runner=16cpu-linux-x64
310-
- run-id=${{ github.run_id }}
275+
runs-on: ubuntu-latest
311276
steps:
312277
- name: Checkout
313278
uses: actions/checkout@v5
314279
- name: Setup Ruby
315280
uses: ruby/setup-ruby@v1
316281
with:
317-
ruby-version: '3.2'
282+
ruby-version: "3.2"
318283
bundler-cache: true
319284
- name: Setup Node
320285
uses: actions/setup-node@v5
321286
with:
322287
node-version: 20
323-
cache: 'npm'
288+
cache: "npm"
324289
- name: NPM Build
325290
run: npm ci
326291
env:
327292
# Disable CSS minification for tests
328-
CI: 'false'
293+
CI: "false"
329294
- name: Test CSS
330295
run: bundle exec rake test:component_css
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
- button "Menu" [expanded]
2+
- dialog "Menu":
3+
- heading "Menu" [level=1]
4+
- button "Close"
5+
- text: Filter
6+
- searchbox "Filter"
7+
- listbox "Menu options":
8+
- option "Item 1"
9+
- option "Item 2"
10+
- option "Item 3"
11+
- text: 3 results tab for results
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- button "Menu"
11 KB
Loading
11 KB
Loading
11.7 KB
Loading
10.4 KB
Loading

0 commit comments

Comments
 (0)