change test

Author: bsatarnejad

app/components/primer/open_project/page_header.rb

@@ -181,9 +181,8 @@ class PageHeader < Primer::Component
         Primer::Beta::IconButton.new(icon: icon, **system_arguments)
       }
 
-      # Optional breadcrumbs above the title row
-      # By default shown on wider screens. Can be overridden with system_argument: display
-      #
+      # Using PageHeader without breadcrumbs is only recommended in special cases.
+      # In doubt, please check the PageHeader component documentation.
       # @param items [Array<String, Hash>] Items is an array of strings, hash {href, text} or an anchor tag string
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       renders_one :breadcrumbs, lambda { |items = nil, selected_item_font_weight: :bold, **system_arguments|
@@ -300,13 +299,6 @@ def show_breadcrumbs?
         breadcrumbs && !breadcrumbs.to_s.strip.empty? || @parent_link.present?
       end
 
-      def render_mobile_action_menu
-        render(@mobile_action_menu) do |menu|
-          menu.with_show_button(icon: :"kebab-horizontal", size: :small, "aria-label": @mobile_menu_label)
-          @desktop_menu_block&.call(menu)
-        end
-      end
-
       def show_context_bar?
         show_breadcrumbs? || actions.any?
       end
@@ -323,6 +315,13 @@ def render_mobile_segmented_control
         render(@mobile_segmented_control, &@mobile_segmented_control_block)
       end
 
+      def render_mobile_action_menu
+        render(@mobile_action_menu) do |menu|
+          menu.with_show_button(icon: :"kebab-horizontal", size: :small, "aria-label": @mobile_menu_label)
+          @desktop_menu_block&.call(menu)
+        end
+      end
+
       def set_action_arguments(system_arguments, scheme: nil)
         system_arguments[:ml] ||= 2
         system_arguments[:display] = %i[none flex]

test/components/primer/open_project/page_header_test.rb

@@ -10,7 +10,18 @@ def test_raises_if_no_title_provided
       render_inline(Primer::OpenProject::PageHeader.new)
     end
 
-    assert_equal("PageHeader needs a title. Please use the `with_title` slot", err.message)
+    assert_equal("PageHeader needs a title and a breadcrumb. Please use the `with_title` and `with_breadcrumbs` slot", err.message)
+  end
+
+  def test_raises_if_no_breadcrumb_provided
+    err = assert_raises ArgumentError do
+      render_inline(Primer::OpenProject::PageHeader.new) do |header|
+        header.with_title { "Hello" }
+      end
+
+    end
+
+    assert_equal("PageHeader needs a title and a breadcrumb. Please use the `with_title` and `with_breadcrumbs` slot", err.message)
   end
 
   def test_renders_title
@@ -282,6 +293,7 @@ def test_skips_a_breadcrumb_item_for_mobile
   def test_renders_without_breadcrumbs
     render_inline(Primer::OpenProject::PageHeader.new) do |header|
       header.with_title { "Hello" }
+      header.with_breadcrumbs()
     end
 
     # Title is rendered
@@ -299,6 +311,7 @@ def test_renders_without_breadcrumbs
   def test_renders_actions_without_breadcrumbs
     render_inline(Primer::OpenProject::PageHeader.new(show_state: true)) do |header|
       header.with_title { "Hello" }
+      header.with_breadcrumbs()
       header.with_action_button(mobile_icon: "pencil", mobile_label: "Edit") { "Edit" }
       header.with_action_icon_button(icon: "trash", mobile_icon: "trash", label: "Delete") { "Delete" }
       header.with_action_link(mobile_icon: "link", mobile_label: "Go to", href: "https://openproject.org") { "Go to OpenProject" }
@@ -310,7 +323,7 @@ def test_renders_actions_without_breadcrumbs
     assert_text("Edit")
     assert_text("Delete")
     assert_text("Go to OpenProject")
-    assert_no_selector(".PageHeader-contextBar")
+    assert_selector(".PageHeader-contextBar")
     assert_no_selector(".PageHeader-breadcrumbs")
     assert_no_selector(".PageHeader-parentLink")
 
@@ -321,6 +334,7 @@ def test_renders_actions_without_breadcrumbs
   def test_renders_with_mobile_segmented_control
     render_inline(Primer::OpenProject::PageHeader.new(show_state: true)) do |header|
       header.with_title { "Title" }
+      header.with_breadcrumbs()
       header.with_action_segmented_control(
         "aria-label": "Segmented control",
         mobile_system_arguments: { hide_labels: true }
@@ -337,6 +351,7 @@ def test_renders_with_mobile_segmented_control
   def test_renders_single_action_with_mobile_action
     render_inline(Primer::OpenProject::PageHeader.new(show_state: true)) do |header|
       header.with_title { "Single Action Test" }
+      header.with_breadcrumbs()
       header.with_action_button(mobile_icon: "plus", mobile_label: "Add") { "Add" }
     end