Change spinner for FeedbackMessgae

Author: HDinger

.changeset/tough-parts-repeat.md

@@ -0,0 +1,5 @@
+---
+'@openproject/primer-view-components': patch
+---
+
+Change loading spinner for FeedbackMessage and FeedbackDialog

app/assets/images/loading_indicator.svg

@@ -39,7 +39,7 @@ def initialize(icon_arguments: {}, loading: false, **system_arguments)
 
       def before_render
         if @loading
-          @blankslate.with_visual_image(src: asset_path("loading_indicator.svg"), alt: I18n.t(:label_loading))
+          @blankslate.with_visual_spinner(size: :large)
         elsif @icon_arguments[:icon] != :none
           @blankslate.with_visual_icon(size: :medium, **@icon_arguments)
         end

app/components/primer/open_project/feedback_message.rb

@@ -81,7 +81,7 @@ def test_renders_loading_spinner
 
     assert_selector("dialog.FeedbackDialog") do
       assert_selector(".Overlay-body h2", text: "Ups, something went wrong")
-      assert_selector("img.blankslate-image[src^='/assets/loading_indicator']")
+      assert_selector("svg[data-test-selector='blankslate-spinner']")
     end
   end
 end

test/components/primer/open_project/feedback_dialog_test.rb

@@ -41,7 +41,7 @@ def test_renders_loading_spinner
     end
 
     assert_selector("h2", text: "Ups, something went wrong")
-    assert_selector("img.blankslate-image[src^='/assets/loading_indicator']")
+    assert_selector("svg[data-test-selector='blankslate-spinner']")
   end
 
   def test_renders_secondary_action