Merge pull request #470 from opf/code-maintenance/typescript-6.0

[DREAM-713] Support TypeScript 6.0

Author: myabc

.changeset/swift-deer-wave.md

@@ -0,0 +1,5 @@
+---
+'@openproject/primer-view-components': patch
+---
+
+Support TypeScript 6.0

.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/filterable_tree_view/default/dark_dimmed.png

@@ -1,7 +1,7 @@
 import {getAnchoredPosition} from '@primer/behaviors'
 import {controller, target} from '@github/catalyst'
 import {IncludeFragmentElement} from '@github/include-fragment-element'
-import type {PrimerTextFieldElement} from 'app/lib/primer/forms/primer_text_field'
+import type {PrimerTextFieldElement} from '../../../lib/primer/forms/primer_text_field'
 import type {AnchorAlignment, AnchorSide} from '@primer/behaviors'
 import type {LiveRegionElement} from '@primer/live-region-element'
 import '@primer/live-region-element'

app/components/primer/alpha/select_panel_element.ts

@@ -13,7 +13,7 @@ export class TreeViewIconPairElement extends HTMLElement {
       this,
       () => Boolean(this.collapsedIcon) && Boolean(this.expandedIcon),
       () => {
-        this.expanded = this.collapsedIcon.hidden
+        this.expanded = Boolean(this.collapsedIcon.hidden)
       },
     )
   }

app/components/primer/alpha/tree_view/tree_view_icon_pair_element.ts

@@ -72,7 +72,7 @@
     "@primer/primitives": "^11.9.0",
     "@primer/stylelint-config": "^13.6.0",
     "@rollup/plugin-node-resolve": "^16.0.1",
-    "@rollup/plugin-typescript": "^8.3.3",
+    "@rollup/plugin-typescript": "^12.3.0",
     "axe-core": "^4.7.1",
     "chokidar-cli": "^3.0.0",
     "cssnano": "^7.0.1",
@@ -92,7 +92,7 @@
     "rollup-plugin-terser": "^7.0.2",
     "stylelint-actions-formatters": "^16.3.1",
     "tslib": "^2.4.0",
-    "typescript": "^5.2.2",
+    "typescript": "^6.0.3",
     "vite": "^8.0.9",
     "vite-plugin-ruby": "^5.2.1"
   },

package-lock.json

@@ -12,7 +12,10 @@ export default {
   },
   plugins: [
     resolve(),
-    typescript(),
+    // Declarations are emitted by the separate `tsc` step (see script/build-assets),
+    // so disable them here. Avoids @rollup/plugin-typescript v12 requiring
+    // declarationDir to sit alongside the bundle output.
+    typescript({declaration: false, declarationDir: undefined}),
     terser({keep_classnames: /Element$/}) // comment out terser in dev if you want debugger statements
   ],
   onwarn: (warning, warn) => {

package.json

@@ -8,13 +8,13 @@
       "dom",
       "dom.iterable"
     ],
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
     "allowSyntheticDefaultImports": true,
     "declaration": true,
     "declarationDir": "./app",
+    "rootDir": "./app",
     "strictPropertyInitialization": false,
     "strict": true,
-    "baseUrl": ".",
     "types": [],
   },
   "include": [