check for added class in the test

Author: bsatarnejad

app/components/primer/open_project/page_header.html.erb

@@ -16,6 +16,7 @@
       <% end %>
     </div>
   <% end %>
+
   <div class="PageHeader-titleBar">
     <%= leading_action %>
     <%= title %>
@@ -27,6 +28,7 @@
       </div>
     <% end %>
   </div>
+
   <%= description %>
   <% if tab_nav %>
     <div class="PageHeader-tabNavBar">

app/components/primer/open_project/page_header.rb

@@ -212,12 +212,9 @@ class PageHeader < Primer::Component
           link_arguments[:display] ||= DEFAULT_PARENT_LINK_DISPLAY
 
           @parent_link = render(Primer::Beta::Link.new(scheme: :primary, muted: true, **link_arguments)) do
-            render(
-              Primer::Beta::Octicon.new(
-                icon: "arrow-left",
-                "aria-label": I18n.t("button_back"),
-                mr: 2
-              )
+            render(Primer::Beta::Octicon.new(icon: "arrow-left",
+                                             "aria-label": I18n.t("button_back"),
+                                             mr: 2)
             ) + content_tag(:span, parent_item[:text])
           end
         end
@@ -274,16 +271,16 @@ def render?
         title? && breadcrumbs?
       end
 
+      def render_mobile_menu?
+        actions.count > 1
+      end
+
       def show_state?
         @state == STATE_DEFAULT
       end
 
       private
 
-      def render_mobile_menu?
-        actions.count > 1
-      end
-
       def set_action_arguments(system_arguments, scheme: nil)
         system_arguments[:ml] ||= 2
         system_arguments[:display] = %i[none flex]

previews/primer/open_project/page_header_preview.rb

@@ -193,10 +193,12 @@ def non_bold_breadcrumbs
 
       # @label Without breadcrumbs
       # A PageHeader example that renders without breadcrumbs.
+      # This should only be done for *entry pages* (such as overview pages).
+      # In case of doubt, please check with the Dream team.
       def without_breadcrumbs
         render(Primer::OpenProject::PageHeader.new) do |header|
           header.with_title { "Hello" }
-          header.with_breadcrumbs()
+          header.with_breadcrumbs(nil)
           header.with_description { "This PageHeader does not have any breadcrumbs." }
           header.with_action_button(mobile_icon: "star", mobile_label: "Star") do |button|
             button.with_leading_visual_icon(icon: "star")

test/components/primer/open_project/page_header_test.rb

@@ -293,7 +293,7 @@ def test_skips_a_breadcrumb_item_for_mobile
   def test_renders_without_breadcrumbs
     render_inline(Primer::OpenProject::PageHeader.new) do |header|
       header.with_title { "Hello" }
-      header.with_breadcrumbs()
+      header.with_breadcrumbs(nil)
     end
 
     # Title is rendered
@@ -304,61 +304,10 @@ def test_renders_without_breadcrumbs
     assert_no_selector(".PageHeader-breadcrumbs")
     assert_no_selector(".PageHeader-parentLink")
 
-    # Context bar should not be rendered when no breadcrumbs or parent link exist
+    # A class should be added to the page header when there is no breadcrumbs
     assert_selector(".PageHeader--noBreadcrumb")
   end
 
-  def test_renders_actions_without_breadcrumbs
-    render_inline(Primer::OpenProject::PageHeader.new(show_state: true)) do |header|
-      header.with_title { "Hello" }
-      header.with_breadcrumbs()
-      header.with_action_button(mobile_icon: "pencil", mobile_label: "Edit") { "Edit" }
-      header.with_action_icon_button(icon: "trash", mobile_icon: "trash", label: "Delete") { "Delete" }
-      header.with_action_link(mobile_icon: "link", mobile_label: "Go to", href: "https://openproject.org") { "Go to OpenProject" }
-    end
-
-    assert_text("Hello")
-    assert_selector(".PageHeader-title")
-    assert_selector(".PageHeader-actions")
-    assert_text("Edit")
-    assert_text("Delete")
-    assert_text("Go to OpenProject")
-    assert_selector(".PageHeader-contextBar")
-    assert_no_selector(".PageHeader-breadcrumbs")
-    assert_no_selector(".PageHeader-parentLink")
-
-    # At least one mobile action button or menu should exist
-    assert_selector(".PageHeader-actions .Button, .PageHeader-actions action-menu", minimum: 1)
-  end
-
-  def test_renders_with_mobile_segmented_control
-    render_inline(Primer::OpenProject::PageHeader.new(show_state: true)) do |header|
-      header.with_title { "Title" }
-      header.with_breadcrumbs()
-      header.with_action_segmented_control(
-        "aria-label": "Segmented control",
-        mobile_system_arguments: { hide_labels: true }
-      ) do |control|
-        control.with_item(label: "Preview", icon: :eye, selected: true)
-        control.with_item(label: "Raw", icon: :"file-code")
-      end
-    end
-
-    assert_selector(".PageHeader-action")
-    assert_selector(".PageHeader-action.SegmentedControl")
-  end
-
-  def test_renders_single_action_with_mobile_action
-    render_inline(Primer::OpenProject::PageHeader.new(show_state: true)) do |header|
-      header.with_title { "Single Action Test" }
-      header.with_breadcrumbs()
-      header.with_action_button(mobile_icon: "plus", mobile_label: "Add") { "Add" }
-    end
-
-    assert_text("Add")
-  end
-
-
   private
 
   def breadcrumb_elements