Skip to content

Commit 3f4fe8d

Browse files
committed
Accept keyword arguments in page header render_in
Upstream's render_in kwargs change updated the beta and tree_view components but not the OpenProject-namespaced PageHeader::Dialog and PageHeader::Menu overrides, which would still raise if render_in is called with keywords. Mirror the sibling pattern (accept and ignore **_kwargs).
1 parent 9fa9eac commit 3f4fe8d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

app/components/primer/open_project/page_header/dialog.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def initialize(dialog_arguments: {}, button_arguments: {})
1919
end
2020
end
2121

22-
def render_in(view_context, &block)
22+
def render_in(view_context, **_kwargs, &block)
2323
super(view_context) do
2424
block&.call(@dialog, @button)
2525
end

app/components/primer/open_project/page_header/menu.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def initialize(menu_arguments: {}, button_arguments: {})
1919
end
2020
end
2121

22-
def render_in(view_context, &block)
22+
def render_in(view_context, **_kwargs, &block)
2323
super(view_context) do
2424
block&.call(@menu, @button)
2525
end

0 commit comments

Comments
 (0)