Skip to content

Commit 62a1b74

Browse files
HDingerHDinger
committed
Disable flickering playwright previews
1 parent 2960010 commit 62a1b74

4 files changed

Lines changed: 0 additions & 30 deletions

File tree

‎playwright.config.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ const config: PlaywrightTestConfig = {
3131
},
3232
toMatchSnapshot: {
3333
threshold: 0.1,
34-
maxDiffPixelRatio: 0.001,
3534
},
3635
},
3736
/* Retry on CI only */

‎previews/primer/alpha/select_panel_preview.rb‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ def playground(
5454

5555
# @label Default
5656
#
57-
# @snapshot interactive
5857
# @param open_on_load toggle
5958
# @param show_filter toggle
6059
def default(open_on_load: false, show_filter: true)
@@ -66,7 +65,6 @@ def default(open_on_load: false, show_filter: true)
6665

6766
# @label Local fetch
6867
#
69-
# @snapshot interactive
7068
# @param open_on_load toggle
7169
# @param show_filter toggle
7270
def local_fetch(open_on_load: false, show_filter: true)
@@ -75,7 +73,6 @@ def local_fetch(open_on_load: false, show_filter: true)
7573

7674
# @label Eventually local fetch
7775
#
78-
# @snapshot interactive
7976
# @param open_on_load toggle
8077
# @param show_filter toggle
8178
def eventually_local_fetch(open_on_load: false, show_filter: true)
@@ -84,7 +81,6 @@ def eventually_local_fetch(open_on_load: false, show_filter: true)
8481

8582
# @label Remote fetch
8683
#
87-
# @snapshot interactive
8884
# @param open_on_load toggle
8985
# @param selected_items text
9086
def remote_fetch(open_on_load: false, selected_items: "Phaser")
@@ -93,7 +89,6 @@ def remote_fetch(open_on_load: false, selected_items: "Phaser")
9389

9490
# @label Custom loading label
9591
#
96-
# @snapshot interactive
9792
# @param open_on_load toggle
9893
# @param selected_items text
9994
def custom_loading_label(open_on_load: false, selected_items: "Phaser")
@@ -102,7 +97,6 @@ def custom_loading_label(open_on_load: false, selected_items: "Phaser")
10297

10398
# @label Custom loading description
10499
#
105-
# @snapshot interactive
106100
# @param open_on_load toggle
107101
# @param selected_items text
108102
def custom_loading_description(open_on_load: false, selected_items: "Phaser")
@@ -111,31 +105,27 @@ def custom_loading_description(open_on_load: false, selected_items: "Phaser")
111105

112106
# @label Local fetch (no results)
113107
#
114-
# @snapshot interactive
115108
# @param open_on_load toggle
116109
def local_fetch_no_results(open_on_load: false)
117110
render_with_template(locals: { open_on_load: open_on_load })
118111
end
119112

120113
# @label Eventually local fetch (no results)
121114
#
122-
# @snapshot interactive
123115
# @param open_on_load toggle
124116
def eventually_local_fetch_no_results(open_on_load: false)
125117
render_with_template(locals: { open_on_load: open_on_load })
126118
end
127119

128120
# @label Remote fetch (no results)
129121
#
130-
# @snapshot interactive
131122
# @param open_on_load toggle
132123
def remote_fetch_no_results(open_on_load: false)
133124
render_with_template(locals: { open_on_load: open_on_load })
134125
end
135126

136127
# @label Single select
137128
#
138-
# @snapshot interactive
139129
# @param dynamic_label toggle
140130
# @param open_on_load toggle
141131
def single_select(dynamic_label: false, open_on_load: false)
@@ -144,7 +134,6 @@ def single_select(dynamic_label: false, open_on_load: false)
144134

145135
# @label Multiselect
146136
#
147-
# @snapshot interactive
148137
# @param open_on_load toggle
149138
def multiselect(open_on_load: false)
150139
render_with_template(locals: { open_on_load: open_on_load })
@@ -154,15 +143,13 @@ def multiselect(open_on_load: false)
154143

155144
# @label With dynamic label
156145
#
157-
# @snapshot interactive
158146
# @param open_on_load toggle
159147
def with_dynamic_label(open_on_load: false)
160148
render_with_template(locals: { open_on_load: open_on_load })
161149
end
162150

163151
# @label With dynamic label and aria prefix
164152
#
165-
# @snapshot interactive
166153
# @param open_on_load toggle
167154
def with_dynamic_label_and_aria_prefix(open_on_load: false)
168155
render_with_template(locals: { open_on_load: open_on_load })
@@ -172,23 +159,20 @@ def with_dynamic_label_and_aria_prefix(open_on_load: false)
172159

173160
# @label Footer buttons
174161
#
175-
# @snapshot interactive
176162
# @param open_on_load toggle
177163
def footer_buttons(open_on_load: false)
178164
render_with_template(locals: { open_on_load: open_on_load })
179165
end
180166

181167
# @label With avatar items
182168
#
183-
# @snapshot interactive
184169
# @param open_on_load toggle
185170
def with_avatar_items(open_on_load: false)
186171
render_with_template(locals: { open_on_load: open_on_load })
187172
end
188173

189174
# @label SelectPanel with Primer::IconButton
190175
#
191-
# @snapshot interactive
192176
# @param open_on_load toggle
193177
def select_panel_with_icon_button(open_on_load: false)
194178
render_with_template(locals: { open_on_load: open_on_load })
@@ -198,15 +182,13 @@ def select_panel_with_icon_button(open_on_load: false)
198182

199183
# @label With leading icons
200184
#
201-
# @snapshot interactive
202185
# @param open_on_load toggle
203186
def with_leading_icons(open_on_load: false)
204187
render_with_template(locals: { open_on_load: open_on_load })
205188
end
206189

207190
# @label With trailing icons
208191
#
209-
# @snapshot interactive
210192
# @param open_on_load toggle
211193
def with_trailing_icons(open_on_load: false)
212194
render_with_template(locals: { open_on_load: open_on_load })
@@ -216,23 +198,20 @@ def with_trailing_icons(open_on_load: false)
216198

217199
# @label With subtitle
218200
#
219-
# @snapshot interactive
220201
# @param open_on_load toggle
221202
def with_subtitle(open_on_load: false)
222203
render_with_template(locals: { open_on_load: open_on_load })
223204
end
224205

225206
# @label Remote fetch initial failure
226207
#
227-
# @snapshot interactive
228208
# @param open_on_load toggle
229209
def remote_fetch_initial_failure(open_on_load: false)
230210
render_with_template(locals: { open_on_load: open_on_load })
231211
end
232212

233213
# @label Remote fetch filter failure
234214
#
235-
# @snapshot interactive
236215
# @param open_on_load toggle
237216
# @param banner_scheme [Symbol] select [danger, warning]
238217
# @param show_results toggle
@@ -253,23 +232,20 @@ def remote_fetch_filter_failure(
253232

254233
# @label Eventually local fetch initial failure
255234
#
256-
# @snapshot interactive
257235
# @param open_on_load toggle
258236
def eventually_local_fetch_initial_failure(open_on_load: false)
259237
render_with_template(locals: { open_on_load: open_on_load })
260238
end
261239

262240
# @label Single-select form
263241
#
264-
# @snapshot interactive
265242
# @param open_on_load toggle
266243
def single_select_form(open_on_load: false, route_format: :html)
267244
render_with_template(locals: { open_on_load: open_on_load, route_format: route_format })
268245
end
269246

270247
# @label Remote fetch form
271248
#
272-
# @snapshot interactive
273249
# @param open_on_load toggle
274250
# @param selected_items text
275251
def remote_fetch_form(open_on_load: false, selected_items: "Phaser", route_format: :html)
@@ -278,23 +254,20 @@ def remote_fetch_form(open_on_load: false, selected_items: "Phaser", route_form
278254

279255
# @label Multi-select form
280256
#
281-
# @snapshot interactive
282257
# @param open_on_load toggle
283258
def multiselect_form(open_on_load: false, route_format: :html)
284259
render_with_template(locals: { open_on_load: open_on_load, route_format: route_format })
285260
end
286261

287262
# @label List of links
288263
#
289-
# @snapshot interactive
290264
# @param open_on_load toggle
291265
def list_of_links(open_on_load: false)
292266
render_with_template(locals: { open_on_load: open_on_load })
293267
end
294268

295269
# @label No values
296270
#
297-
# @snapshot interactive
298271
# @param open_on_load toggle
299272
def no_values(open_on_load: false)
300273
render_with_template(locals: { open_on_load: open_on_load })

‎previews/primer/alpha/text_area_preview.rb‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ def with_character_limit
107107
end
108108

109109
# @label With character limit, over limit
110-
# @snapshot interactive
111110
def with_character_limit_over_limit
112111
render(Primer::Alpha::TextArea.new(id: "my-text-area-with-character-limit-over-limit", name: "my-text-area-with-character-limit-over-limit", character_limit: 10, label: "Tell me about yourself", value: "This text is definitely over the limit."))
113112
end

‎previews/primer/alpha/text_field_preview.rb‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,6 @@ def with_character_limit
236236
end
237237

238238
# @label With character limit, over limit
239-
# @snapshot interactive
240239
def with_character_limit_over_limit
241240
render(Primer::Alpha::TextField.new(character_limit: 10, name: "my-text-field-19", label: "Tell me about yourself", value: "This text is definitely over the limit."))
242241
end

0 commit comments

Comments
 (0)