Skip to content

Commit 6bb1334

Browse files
committed
Simplify the enforce_consistent_button_size method
1 parent e6d79c0 commit 6bb1334

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

app/components/primer/open_project/page_header.rb

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -311,17 +311,14 @@ def set_action_arguments(system_arguments, scheme: nil)
311311
end
312312

313313
def enforce_consistent_button_size!(system_arguments)
314-
size = system_arguments.key?(:size) ? system_arguments[:size] : DEFAULT_BUTTON_ACTION_SIZE
314+
size = system_arguments.fetch(:size, DEFAULT_BUTTON_ACTION_SIZE)
315315
@page_header_button_action_size ||= size
316-
317-
if size != @page_header_button_action_size
316+
unless size == @page_header_button_action_size
318317
raise ArgumentError,
319318
"PageHeader button actions must all use the same size. " \
320319
"Set the same `size:` for every button-like action (or omit it to use #{DEFAULT_BUTTON_ACTION_SIZE.inspect} everywhere)."
321320
end
322-
323-
system_arguments[:size] = size
324-
system_arguments
321+
system_arguments.merge(size: @page_header_button_action_size)
325322
end
326323

327324
def create_mobile_alternatives(component, mobile_icon, mobile_label, scheme, **system_arguments, &block)

0 commit comments

Comments
 (0)