Merge pull request #284 from opf/bump/primer-upstream

Bump/primer upstream 0.43.0

Author: HDinger

.changeset/hip-cherries-glow.md

@@ -0,0 +1,5 @@
+---
+"@openproject/primer-view-components": patch
+---
+
+Add a new custom label for close button in dialog header

.changeset/modern-cheetahs-thank.md

@@ -0,0 +1,5 @@
+---
+"@openproject/primer-view-components": patch
+---
+
+Fix(SelectPanel): incorrect padding when no filter

.changeset/sour-beds-draw.md

@@ -0,0 +1,5 @@
+---
+'@openproject/primer-view-components': minor
+---
+
+Create Primer::CurrentAttributes allowing apps to set request specific context to components. Update IncludeFragment to add data-nonce when a current nonce is present.

.github/workflows/lint.yml

@@ -16,7 +16,7 @@ jobs:
     - uses: actions/checkout@v4
     - name: Get specific changed files
       id: changed-files
-      uses: tj-actions/changed-files@6cb76d07bee4c9772c6882c06c37837bf82a04d3
+      uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c
       with:
         files: |
           docs/**/*.md
@@ -42,7 +42,7 @@ jobs:
     - uses: actions/checkout@v4
     - name: Get specific changed files
       id: changed-files
-      uses: tj-actions/changed-files@6cb76d07bee4c9772c6882c06c37837bf82a04d3
+      uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c
       with:
         files: |
           app/**/*.rb
@@ -62,7 +62,7 @@ jobs:
     - uses: actions/checkout@v4
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/changed-files@6cb76d07bee4c9772c6882c06c37837bf82a04d3
+      uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c
       with:
         files: |
           app/components/**/*.erb
@@ -79,7 +79,7 @@ jobs:
     - uses: actions/checkout@v4
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/changed-files@6cb76d07bee4c9772c6882c06c37837bf82a04d3
+      uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c
       with:
         files: |
           app/components/**/*.ts
@@ -99,7 +99,7 @@ jobs:
     - uses: actions/checkout@v4
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/changed-files@6cb76d07bee4c9772c6882c06c37837bf82a04d3
+      uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c
       with:
         files: |
           app/components/**/*.pcss

Gemfile

@@ -36,7 +36,7 @@ gem "bootsnap", ">= 1.4.2", require: false
 gem "lookbook", "~> 2.3.8"
 gem "view_component", path: ENV["VIEW_COMPONENT_PATH"] if ENV["VIEW_COMPONENT_PATH"]
 
-gem "kramdown", "~> 2.4"
+gem "kramdown", "~> 2.5"
 gem "sourcemap", "~> 0.1"
 
 gem "cssbundling-rails", "~> 1.4"

Gemfile.lock

@@ -4,7 +4,7 @@ PATH
     openproject-primer_view_components (0.63.0)
       actionview (>= 7.1.0)
       activesupport (>= 7.1.0)
-      openproject-octicons (>= 19.23.0)
+      openproject-octicons (>= 19.25.0)
       view_component (>= 3.1, < 4.0)
 
 GEM
@@ -115,8 +115,8 @@ GEM
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
     json (2.7.2)
-    kramdown (2.4.0)
-      rexml
+    kramdown (2.5.1)
+      rexml (>= 3.3.9)
     language_server-protocol (3.17.0.3)
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
@@ -153,7 +153,7 @@ GEM
       racc (~> 1.4)
     nokogiri (1.18.7-x86_64-linux-gnu)
       racc (~> 1.4)
-    openproject-octicons (19.23.0)
+    openproject-octicons (19.25.0)
     parallel (1.26.3)
     parser (3.3.5.0)
       ast (~> 2.4.1)
@@ -318,7 +318,7 @@ DEPENDENCIES
   debug
   erb_lint (~> 0.6)
   erblint-github (~> 1.0)
-  kramdown (~> 2.4)
+  kramdown (~> 2.5)
   listen (~> 3.9)
   lookbook (~> 2.3.8)
   matrix (~> 0.4.2)

app/components/primer/alpha/dialog/header.html.erb

@@ -13,7 +13,7 @@
       <% end %>
     </div>
     <div class="Overlay-actionWrap">
-      <%= render Primer::Beta::CloseButton.new(classes: "Overlay-closeButton", "data-close-dialog-id": @id) %>
+      <%= render Primer::Beta::CloseButton.new(classes: "Overlay-closeButton", "data-close-dialog-id": @id, aria: { label: @close_label }) %>
     </div>
   </div>
   <%= filter %>

app/components/primer/alpha/dialog/header.rb

@@ -16,6 +16,8 @@ class Header < Primer::Component
         }.freeze
         VARIANT_OPTIONS = VARIANT_MAPPINGS.keys
 
+        DEFAULT_CLOSE_LABEL = "Close"
+
         # Optional filter slot for adding a filter input to the header.
         #
         # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
@@ -48,6 +50,7 @@ class Header < Primer::Component
         # @param show_divider [Boolean] Show a divider between the header and body.
         # @param visually_hide_title [Boolean] Visually hide the `title` while maintaining a label for assistive technologies.
         # @param variant [Symbol] <%= one_of(Primer::Alpha::Dialog::Header::VARIANT_OPTIONS) %>
+        # @param close_label [String] The aria-label text of the close "x" button.
         # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
         def initialize(
           id:,
@@ -56,12 +59,14 @@ def initialize(
           show_divider: false,
           visually_hide_title: false,
           variant: DEFAULT_VARIANT,
+          close_label: DEFAULT_CLOSE_LABEL,
           **system_arguments
         )
           @id = id
           @title = title
           @subtitle = subtitle
           @visually_hide_title = visually_hide_title
+          @close_label = close_label
           @system_arguments = deny_tag_argument(**system_arguments)
           @system_arguments[:tag] = :div
 

app/components/primer/alpha/include_fragment.rb

@@ -8,14 +8,27 @@ module Alpha
     class IncludeFragment < Primer::Component
       status :alpha
 
+      ALLOWED_LOADING_VALUES = [:lazy, :eager].freeze
+      DEFAULT_LOADING = :eager
+
       # @param src [String] The URL  from which to retrieve an HTML element fragment.
       # @param loading [Symbol] <%= one_of([:lazy, :eager]) %>
+      # @param accept [String] What to send as the Accept header.
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
-      def initialize(src: nil, loading: :eager, **system_arguments)
+      def initialize(src: nil, loading: nil, accept: nil, **system_arguments)
         @system_arguments = system_arguments
         @system_arguments[:tag] = "include-fragment"
         @system_arguments[:loading] = loading
         @system_arguments[:src] = src
+        @system_arguments[:accept] = accept if accept
+
+        if loading
+          @system_arguments[:loading] = fetch_or_fallback(ALLOWED_LOADING_VALUES, loading.to_sym, DEFAULT_LOADING)
+        end
+
+        if Primer::CurrentAttributes.nonce
+          @system_arguments[:"data-nonce"] = Primer::CurrentAttributes.nonce
+        end
       end
 
       def call

app/components/primer/alpha/select_panel.html.erb

@@ -50,7 +50,7 @@
           <% end %>
         <% end %>
       <% end %>
-      <%= render Primer::Alpha::Dialog::Body.new(mt: show_filter? ? 0 : 2, p: 0) do %>
+      <%= render Primer::Alpha::Dialog::Body.new(p: 0) do %>
         <focus-group direction="vertical" mnemonics retain>
           <live-region data-target="select-panel.liveRegion"></live-region>
           <%= render(Primer::BaseComponent.new(