Skip to content

Commit c165e59

Browse files
authored
Merge pull request #164 from opf/bump/primer-upstream
Bump/primer upstream ref 0.32.0
2 parents 18bd412 + 65c070e commit c165e59

75 files changed

Lines changed: 6680 additions & 1655 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.changeset/brave-bugs-tap.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@openproject/primer-view-components': patch
3+
---
4+
5+
Ensure ActionMenu restores focus on close of a dialog, if a menu item opened that dialog

.changeset/brown-tables-do.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
'@openproject/primer-view-components': patch
3+
---
4+
5+
Fixes several SelectPanel bugs:
6+
7+
1. If multiple server-rendered items are checked, the panel will only show one item checked.
8+
2. If no `data-value` attributes are provided, panels in single-select mode will allow multiple items to be checked.

.changeset/chatty-jokes-walk.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@openproject/primer-view-components': minor
3+
---
4+
5+
Include value in event metadata when SelectPanel items are activated

.changeset/khaki-waves-lie.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@openproject/primer-view-components': patch
3+
---
4+
5+
Remove "loading" screenreader-only text after Spinner load for
6+
`eventually_local` SelectPanels

.changeset/quick-falcons-cheat.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@openproject/primer-view-components": patch
3+
---
4+
5+
Fix a bug where all requests from the `ToggleSwitch` view component are being made with a Turbo Accept header.
6+
This started happening after the change in #2964 because `data-turbo=false` gets interpreted as a truthy value.

.github/workflows/test.yml

Lines changed: 75 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@ env:
2020
jobs:
2121
accessibility:
2222
name: Accessibility
23-
runs-on: ubuntu-latest
23+
runs-on:
24+
labels:
25+
- runs-on
26+
- runner=16cpu-linux-x64
27+
- run-id=${{ github.run_id }}
2428
steps:
2529
- uses: actions/checkout@v4
2630
- uses: ruby/setup-ruby@v1
@@ -42,7 +46,11 @@ jobs:
4246
run: bundle exec rake test:accessibility
4347
components:
4448
name: Components
45-
runs-on: ubuntu-latest
49+
runs-on:
50+
labels:
51+
- runs-on
52+
- runner=16cpu-linux-x64
53+
- run-id=${{ github.run_id }}
4654
strategy:
4755
fail-fast: false
4856
matrix:
@@ -90,7 +98,11 @@ jobs:
9098
RAILS_VERSION: ${{ matrix.rails_version }}
9199
lib:
92100
name: Lib
93-
runs-on: ubuntu-latest
101+
runs-on:
102+
labels:
103+
- runs-on
104+
- runner=16cpu-linux-x64
105+
- run-id=${{ github.run_id }}
94106
strategy:
95107
fail-fast: false
96108
matrix:
@@ -229,60 +241,68 @@ jobs:
229241
timeout-minutes: 20
230242
runs-on: ubuntu-latest
231243
steps:
232-
- uses: actions/checkout@v4
233-
- uses: ruby/setup-ruby@v1
234-
with:
235-
ruby-version: '3.2'
236-
bundler-cache: true
237-
- uses: actions/setup-node@v4
238-
with:
239-
node-version: 16
240-
cache: 'npm'
241-
cache-dependency-path: |
242-
package-lock.json
243-
demo/package-lock.json
244-
- name: Build
245-
run: |
246-
npm ci
247-
bundle install
248-
bundle exec rake static:dump
249-
cd demo
250-
npm ci
251-
bundle install
252-
- name: Install Playwright Browsers
253-
run: npx playwright install --with-deps
254-
- name: Run Playwright tests
255-
id: playwright-run
256-
continue-on-error: true
257-
run: npx playwright test --workers 6
258-
- id: auto-commit
259-
uses: stefanzweifel/git-auto-commit-action@v5
260-
with:
261-
commit_message: Generating component snapshots
262-
file_pattern: .playwright/screenshots/**/*.png
263-
- name: "Changes detected"
264-
if: steps.auto-commit.outputs.changes_detected == 'true'
265-
uses: phulsechinmay/rewritable-pr-comment@v0.3.0
266-
with:
267-
message: |
268-
### ⚠️ Visual differences found
269-
270-
Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.
271-
272-
[Review visual differences](https://github.com/opf/primer_view_components/pull/${{ github.event.number }}/files?file-filters%5B%5D=.png&show-viewed-files=false)
273-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
274-
COMMENT_IDENTIFIER: 'visual-comparison-diff'
275-
- uses: actions/upload-artifact@v4
276-
with:
277-
name: playwright-report
278-
path: .playwright/report/
279-
retention-days: 30
280-
- name: Failure
281-
if: ${{ steps.auto-commit.outputs.changes_detected == 'true' || steps.playwright-run.outcome == 'failure' }}
282-
run: exit 1
244+
- uses: actions/checkout@v4
245+
- uses: ruby/setup-ruby@v1
246+
with:
247+
ruby-version: '3.2'
248+
bundler-cache: true
249+
- uses: actions/setup-node@v4
250+
with:
251+
node-version: 16
252+
cache: 'npm'
253+
cache-dependency-path: |
254+
package-lock.json
255+
demo/package-lock.json
256+
- name: Build
257+
run: |
258+
npm ci
259+
bundle install
260+
bundle exec rake static:dump
261+
cd demo
262+
npm ci
263+
bundle install
264+
- name: Install Overmind
265+
run: |
266+
sudo apt-get install tmux
267+
gem install overmind
268+
- name: Install Playwright Browsers
269+
run: npx playwright install --with-deps
270+
- name: Run Playwright tests
271+
id: playwright-run
272+
continue-on-error: true
273+
run: npx playwright test --workers 6
274+
- id: auto-commit
275+
uses: stefanzweifel/git-auto-commit-action@v5
276+
with:
277+
commit_message: Generating component snapshots
278+
file_pattern: .playwright/screenshots/**/*.png
279+
- name: "Changes detected"
280+
if: steps.auto-commit.outputs.changes_detected == 'true'
281+
uses: phulsechinmay/rewritable-pr-comment@v0.3.0
282+
with:
283+
message: |
284+
### ⚠️ Visual differences found
285+
286+
Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.
287+
288+
[Review visual differences](https://github.com/opf/primer_view_components/pull/${{ github.event.number }}/files?file-filters%5B%5D=.png&show-viewed-files=false)
289+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
290+
COMMENT_IDENTIFIER: 'visual-comparison-diff'
291+
- uses: actions/upload-artifact@v4
292+
with:
293+
name: playwright-report
294+
path: .playwright/report/
295+
retention-days: 30
296+
- name: Failure
297+
if: ${{ steps.auto-commit.outputs.changes_detected == 'true' || steps.playwright-run.outcome == 'failure' }}
298+
run: exit 1
283299
selectors:
284300
name: CSS coverage
285-
runs-on: ubuntu-latest
301+
runs-on:
302+
labels:
303+
- runs-on
304+
- runner=16cpu-linux-x64
305+
- run-id=${{ github.run_id }}
286306
steps:
287307
- name: Checkout
288308
uses: actions/checkout@v4

.gitignore

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,13 @@ tmp/
4747

4848
# Simplecov folder
4949
coverage/
50+
51+
# Assets
5052
demo/public/assets/
53+
demo/public/vite-test/
54+
demo/public/vite-dev/
55+
demo/public/vite/
56+
demo/app/assets/builds/
5157

5258
# IDE folders
5359
.idea
-135 Bytes
Loading
-135 Bytes
Loading
-134 Bytes
Loading

0 commit comments

Comments
 (0)