Skip to content

Commit cee80e2

Browse files
authored
Merge pull request #490 from opf/fix/playwright-tests-2
Remove some constantly failing previews from the playwright testing
2 parents a1f91e0 + 19295cc commit cee80e2

4 files changed

Lines changed: 9 additions & 13 deletions

File tree

previews/primer/alpha/segmented_control_preview.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ def full_width_medium(hide_labels: false)
5858
# @!endgroup
5959

6060
# @!group Icons and text
61-
# @label Size small
6261
# @snapshot
6362
def icons_and_text_small
6463
render(Primer::Alpha::SegmentedControl.new("aria-label": "File view", size: :small)) do |component|
@@ -69,7 +68,6 @@ def icons_and_text_small
6968
end
7069

7170
# @label Size medium
72-
# @snapshot
7371
def icons_and_text_medium
7472
render(Primer::Alpha::SegmentedControl.new("aria-label": "File view", size: :medium)) do |component|
7573
component.with_item(label: "Preview", icon: :eye, selected: true)
@@ -81,7 +79,6 @@ def icons_and_text_medium
8179

8280
# @!group Trailing Label
8381
# @label Size small
84-
# @snapshot
8582
def trailing_label_width_small
8683
render(Primer::Alpha::SegmentedControl.new("aria-label": "Billing duration", size: :small)) do |component|
8784
component.with_item(label: "Monthly")
@@ -92,7 +89,6 @@ def trailing_label_width_small
9289
end
9390

9491
# @label Size medium
95-
# @snapshot
9692
def trailing_label_width_medium
9793
render(Primer::Alpha::SegmentedControl.new("aria-label": "Billing duration", size: :medium)) do |component|
9894
component.with_item(label: "Monthly")

previews/primer/open_project/filterable_tree_view_preview.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def playground(expanded: true, select_variant: :multiple, show_checkbox: true, s
2121

2222
# @label Default
2323
#
24-
# @snapshot interactive
24+
# @snapshot
2525
# @param expanded [Boolean] toggle
2626
def default(expanded: true)
2727
render_with_template(locals: {

static/info_arch.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7301,7 +7301,7 @@
73017301
{
73027302
"preview_path": "primer/alpha/segmented_control/icons_and_text_medium",
73037303
"name": "icons_and_text_medium",
7304-
"snapshot": "true",
7304+
"snapshot": "false",
73057305
"skip_rules": {
73067306
"wont_fix": [
73077307
"region"
@@ -7314,7 +7314,7 @@
73147314
{
73157315
"preview_path": "primer/alpha/segmented_control/trailing_label_width_small",
73167316
"name": "trailing_label_width_small",
7317-
"snapshot": "true",
7317+
"snapshot": "false",
73187318
"skip_rules": {
73197319
"wont_fix": [
73207320
"region"
@@ -7327,7 +7327,7 @@
73277327
{
73287328
"preview_path": "primer/alpha/segmented_control/trailing_label_width_medium",
73297329
"name": "trailing_label_width_medium",
7330-
"snapshot": "true",
7330+
"snapshot": "false",
73317331
"skip_rules": {
73327332
"wont_fix": [
73337333
"region"
@@ -20443,7 +20443,7 @@
2044320443
{
2044420444
"preview_path": "primer/open_project/filterable_tree_view/default",
2044520445
"name": "default",
20446-
"snapshot": "interactive",
20446+
"snapshot": "true",
2044720447
"skip_rules": {
2044820448
"wont_fix": [
2044920449
"region"

static/previews.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4440,7 +4440,7 @@
44404440
{
44414441
"preview_path": "primer/open_project/filterable_tree_view/default",
44424442
"name": "default",
4443-
"snapshot": "interactive",
4443+
"snapshot": "true",
44444444
"skip_rules": {
44454445
"wont_fix": [
44464446
"region"
@@ -7203,7 +7203,7 @@
72037203
{
72047204
"preview_path": "primer/alpha/segmented_control/icons_and_text_medium",
72057205
"name": "icons_and_text_medium",
7206-
"snapshot": "true",
7206+
"snapshot": "false",
72077207
"skip_rules": {
72087208
"wont_fix": [
72097209
"region"
@@ -7216,7 +7216,7 @@
72167216
{
72177217
"preview_path": "primer/alpha/segmented_control/trailing_label_width_small",
72187218
"name": "trailing_label_width_small",
7219-
"snapshot": "true",
7219+
"snapshot": "false",
72207220
"skip_rules": {
72217221
"wont_fix": [
72227222
"region"
@@ -7229,7 +7229,7 @@
72297229
{
72307230
"preview_path": "primer/alpha/segmented_control/trailing_label_width_medium",
72317231
"name": "trailing_label_width_medium",
7232-
"snapshot": "true",
7232+
"snapshot": "false",
72337233
"skip_rules": {
72347234
"wont_fix": [
72357235
"region"

0 commit comments

Comments
 (0)