Skip to content

Commit d35389f

Browse files
committed
Update data path attribute for loading elements to avoid escaping special characters
1 parent bc6f848 commit d35389f

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

app/components/primer/alpha/tree_view/skeleton_loader.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<% with_loading_failure_message # set the default %>
33
<% end %>
44

5-
<%= render(Primer::BaseComponent.new(tag: :"tree-view-include-fragment", src: @src, loading: :lazy, data: { target: "tree-view-sub-tree-node.subTree tree-view-sub-tree-node.includeFragment", path: @container.path.to_json }, hidden: @container.expanded?, accept: "text/fragment+html")) do %>
5+
<%= render(Primer::BaseComponent.new(tag: :"tree-view-include-fragment", src: @src, loading: :lazy, data: { target: "tree-view-sub-tree-node.subTree tree-view-sub-tree-node.includeFragment", path: JSON.generate(@container.path) }, hidden: @container.expanded?, accept: "text/fragment+html")) do %>
66
<%= render(@container) do %>
77
<%= render(Primer::Alpha::TreeView::Node.new(path: [*@container.path, :loader], node_variant: :div)) do |node| %>
88
<% node.with_text_content do %>

app/components/primer/alpha/tree_view/spinner_loader.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<% with_loading_failure_message # set the default %>
33
<% end %>
44

5-
<%= render(Primer::BaseComponent.new(tag: :"tree-view-include-fragment", src: @src, loading: :lazy, data: { target: "tree-view-sub-tree-node.subTree tree-view-sub-tree-node.includeFragment", path: @container.path.to_json }, hidden: @container.expanded?, accept: "text/fragment+html")) do %>
5+
<%= render(Primer::BaseComponent.new(tag: :"tree-view-include-fragment", src: @src, loading: :lazy, data: { target: "tree-view-sub-tree-node.subTree tree-view-sub-tree-node.includeFragment", path: JSON.generate(@container.path) }, hidden: @container.expanded?, accept: "text/fragment+html")) do %>
66
<%= render(@container) do %>
77
<%= render(Primer::Alpha::TreeView::Node.new(path: [*@container.path, :loader], data: { target: "tree-view-sub-tree-node.loadingIndicator" }, node_variant: :div)) do |node| %>
88
<% node.with_text_content { "Loading..." } %>

0 commit comments

Comments
 (0)