enforce consistent size for button actions

Author: bsatarnejad

app/components/primer/open_project/page_header.rb

@@ -25,6 +25,8 @@ class PageHeader < Primer::Component
       DEFAULT_PARENT_LINK_DISPLAY = [:block, :none].freeze
       BREADCRUMB_TRUNCATE_AT = 200
 
+      DEFAULT_BUTTON_ACTION_SIZE = :medium
+
       STATE_DEFAULT = :show
       STATE_EDIT = :edit
       STATE_OPTIONS = [STATE_DEFAULT, STATE_EDIT].freeze
@@ -68,6 +70,7 @@ class PageHeader < Primer::Component
           system_arguments[:icon] = icon
           system_arguments[:"aria-label"] ||= label
           system_arguments = set_action_arguments(system_arguments, scheme: scheme)
+          system_arguments = enforce_consistent_button_size!(system_arguments)
 
           component = Primer::Beta::IconButton
           create_mobile_alternatives(component, mobile_icon, label, scheme, **system_arguments, &block)
@@ -78,6 +81,7 @@ class PageHeader < Primer::Component
           deny_tag_argument(**system_arguments)
 
           system_arguments = set_action_arguments(system_arguments, scheme: scheme)
+          system_arguments = enforce_consistent_button_size!(system_arguments)
 
           component = Primer::Beta::Button
           create_mobile_alternatives(component, mobile_icon, mobile_label, scheme, **system_arguments, &block)
@@ -88,6 +92,7 @@ class PageHeader < Primer::Component
           deny_tag_argument(**system_arguments)
 
           system_arguments = set_action_arguments(system_arguments, scheme: DEFAULT_ACTION_SCHEME)
+          system_arguments = enforce_consistent_button_size!(system_arguments)
 
           component = Primer::OpenProject::ZenModeButton
           create_mobile_alternatives(component, mobile_icon, mobile_label, DEFAULT_ACTION_SCHEME, **system_arguments, &block)
@@ -120,6 +125,7 @@ class PageHeader < Primer::Component
 
             system_arguments[:button_arguments] ||= {}
             system_arguments[:button_arguments] = set_action_arguments(system_arguments[:button_arguments])
+            system_arguments[:button_arguments] = enforce_consistent_button_size!(system_arguments[:button_arguments])
 
             # Add the options individually to the mobile menu in the template
             @desktop_menu_block = block
@@ -138,6 +144,7 @@ class PageHeader < Primer::Component
             system_arguments[:button_arguments] ||= {}
             system_arguments[:button_arguments][:id] = "dialog-show-#{system_arguments[:dialog_arguments][:id]}"
             system_arguments[:button_arguments] = set_action_arguments(system_arguments[:button_arguments])
+            system_arguments[:button_arguments] = enforce_consistent_button_size!(system_arguments[:button_arguments])
 
             component = Primer::OpenProject::PageHeader::Dialog
             create_mobile_alternatives(component, mobile_icon, mobile_label, :default, **system_arguments, &block)
@@ -291,17 +298,8 @@ def show_state?
       private
 
       def set_action_arguments(system_arguments, scheme: nil)
-        requested_size = system_arguments.key?(:size) ? system_arguments[:size] : :medium
-        @page_header_action_size ||= requested_size
-
-        if requested_size != @page_header_action_size
-          raise ArgumentError,
-                "PageHeader actions must all use the same size. Set the same `size:` for every action (or omit it to use :medium everywhere)."
-        end
-
         system_arguments[:ml] ||= 2
         system_arguments[:display] = %i[none flex]
-        system_arguments[:size] = requested_size
         system_arguments[:scheme] = scheme unless scheme.nil?
         system_arguments[:classes] = class_names(
           system_arguments[:classes],
@@ -312,6 +310,20 @@ def set_action_arguments(system_arguments, scheme: nil)
         system_arguments
       end
 
+      def enforce_consistent_button_size!(system_arguments)
+        size = system_arguments.key?(:size) ? system_arguments[:size] : DEFAULT_BUTTON_ACTION_SIZE
+        @page_header_button_action_size ||= size
+
+        if size != @page_header_button_action_size
+          raise ArgumentError,
+                "PageHeader button actions must all use the same size. " \
+                  "Set the same `size:` for every button-like action (or omit it to use #{DEFAULT_BUTTON_ACTION_SIZE.inspect} everywhere)."
+        end
+
+        system_arguments[:size] = size
+        system_arguments
+      end
+
       def create_mobile_alternatives(component, mobile_icon, mobile_label, scheme, **system_arguments, &block)
         # All actions should collapse into a single actionMenu on mobile
         add_option_to_mobile_menu(system_arguments, mobile_icon, mobile_label, scheme)