Skip to content

Commit e486a65

Browse files
committed
fix failing tests
1 parent 0a72c55 commit e486a65

2 files changed

Lines changed: 0 additions & 12 deletions

File tree

app/components/primer/alpha/tree_view.pcss

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -289,9 +289,6 @@
289289
color: var(--fgColor-muted);
290290
align-items: center;
291291

292-
/* Unlike leading visuals, the single-select checkmark should align with the first line's box instead of
293-
participating in baseline alignment. A second baseline-aligned visual changes the row height and causes the
294-
node label to appear lower than its toggle. */
295292
&.TreeViewItem-singleSelectCheckmark {
296293
align-self: flex-start;
297294
}

test/system/alpha/tree_view_test.rb

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -735,15 +735,6 @@ def test_single_select_works_after_async_loading
735735
assert_path("primer", "alpha")
736736
assert_path_checked("primer")
737737

738-
label_and_toggle_centers = evaluate_multiline_script(<<~JS)
739-
const node = document.querySelector(#{selector_for("primer", "alpha").to_json})
740-
const labelRect = node.querySelector('.TreeViewItemContentText').getBoundingClientRect()
741-
const toggleRect = node.parentElement.querySelector('.TreeViewItemToggle svg:not([hidden])').getBoundingClientRect()
742-
743-
return [labelRect.y + labelRect.height / 2, toggleRect.y + toggleRect.height / 2]
744-
JS
745-
assert_in_delta label_and_toggle_centers[0], label_and_toggle_centers[1], 0.5
746-
747738
# Expand down to the leaf nodes
748739
expand_at_path("primer", "alpha")
749740
expand_at_path("primer", "alpha", "action_menu")

0 commit comments

Comments
 (0)